Remove lock wrappers in sys_common

[joboet]

This moves the lazy allocation to sys (SGX and UNIX). While this leads to a bit more verbosity, it will simplify future improvements by making room in sys_common for platform-independent implementations.

This also removes the condvar check on SGX as it is not necessary for soundness and will be removed anyway once mutex has been made movable.

For simplicity's sake, libunwind also uses lazy allocation now on SGX. This will require an update to the C definitions before merging this (CC @raoulstrackx).

r? @m-ou-se

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[m-ou-se]

Nice! This is great. I haven't finished reviewing the diff yet, but I'm really happy to finally get the lock wrappers in sys_common removed.

[m-ou-se]

Thank you!

@bors r+ rollup=never

[bors]

📌 Commit d57bb300e78058bc02965f582a4cb3acd7a48d31 has been approved by m-ou-se

It is now in the queue for this repository.

[joboet]

@bors r-
I think the SGX fork of libunwind needs to be updated first.

[joboet]

@m-ou-se this should be good to go now. Thank you for the review!

@rustbot ready

[m-ou-se]

@bors r+

[bors]

📌 Commit 168f1f1 has been approved by m-ou-se

It is now in the queue for this repository.

[joboet]

@m-ou-se Could you try again?

[m-ou-se]

@bors r+

[bors]

📌 Commit 3e35cfb4b9f08090ed9959f3337cae53b39de32c has been approved by m-ou-se

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3e35cfb4b9f08090ed9959f3337cae53b39de32c with merge dd7fc2725173977b5a742999700146c50530b659...

[bors]

💔 Test failed - checks-actions

[joboet]

Sorry for taking up so much time; I didn't read the error messages carefully enough (twice 🤦).
@m-ou-se could we try it once more, please?

[m-ou-se]

No worries. :)

@bors r+

[bors]

📌 Commit f30614a has been approved by m-ou-se

It is now in the queue for this repository.

[bors]

⌛ Testing commit f30614a with merge b0c6527...

[bors]

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing b0c6527 to master...

[rust-timer]

Finished benchmarking commit (b0c6527): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0