Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use token::Lit in ast::ExprKind::Lit. #102944

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Use token::Lit in ast::ExprKind::Lit. #102944

merged 3 commits into from
Nov 17, 2022

Commits on Nov 15, 2022

  1. Add a test for different stages of lexer error reporting.

    @nnethercote
    nnethercote committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b8db4a3 View commit details
    Browse the repository at this point in the history

  2. Add some more bad suffix cases in a test.

    @nnethercote
    nnethercote committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0176026 View commit details
    Browse the repository at this point in the history

  3. Use token::Lit in ast::ExprKind::Lit. 

    Instead of `ast::Lit`.

Literal lowering now happens at two different times. Expression literals
are lowered when HIR is crated. Attribute literals are lowered during
parsing.

This commit changes the language very slightly. Some programs that used
to not compile now will compile. This is because some invalid literals
that are removed by `cfg` or attribute macros will no longer trigger
errors. See this comment for more details:
rust-lang#102944 (comment)
    @nnethercote
    nnethercote committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    358a603 View commit details
    Browse the repository at this point in the history