-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #102802
Closed
Closed
Rollup of 7 pull requests #102802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .gitattributes: Mark minified javascript as binary to filter greps - fix very minor punctuation typo - diagnostic structs: derive on enum (rust-lang#1477) - Update running tests with the new flags (rust-lang#1476) - Rename typeck to hir_analysis (rust-lang#1475) - fix typo and make paragraph consistent (rust-lang#1474) - Update about-this-guide.md - Link to the correct page in "about this guide" - Update r-a config suggestions - don't refer to the compile-time interpreter as "Miri" (rust-lang#1471) - UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558 - Update mdbook and its extensions versions - Remove unmaintained action - Update some actions versions - Fix some typos Update motivated in large part by the most recent commit, to fix `git grep`.
…piler-errors Allow transmutes between the same types after erasing lifetimes r? ``@compiler-errors`` on the impl fixes rust-lang#101081 See discussion in the issue and at https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/.23101081.3A.20Regression.20transmuting.20.60RwLockReadGuard.3CT.3A.20.3FSized.3E.E2.80.A6 I think this may need lang team signoff as its implications may go beyond the jurisdiction of T-types I'll write up a proper summary later
…AGS, r=notriddle Change default level of INVALID_HTML_TAGS to warning and stabilize it Fixes of rust-lang#67799. cc ``@Nemo157`` r? ``@notriddle``
Remove `mir::CastKind::Misc` As discussed in rust-lang#97649 `mir::CastKind::Misc` is not clear, this PR addresses that by creating a new enum variant for every valid cast. r? ``@oli-obk``
Fix MIR inlining of asm_unwind The MIR inlining currently doesn't handle inline asm's unwind edge correctly. This code will cause ICE: ```rust struct D; impl Drop for D { fn drop(&mut self) {} } #[inline(always)] fn foo() { let _d = D; unsafe { std::arch::asm!("", options(may_unwind)) }; } pub fn main() { foo(); } ``` This PR fixes this issue. I also take the opportunity to extract common code into a method.
…d, r=compiler-errors Remove `DefId` from some `SelectionCandidate` variants They are both from `obligation.predicate.def_id()`, which do not need to be on the `SelectionCandidate`. cc ``@lcnr`` ``@compiler-errors``
… r=ehuss Update rustc-dev-guide - .gitattributes: Mark minified javascript as binary to filter greps - fix very minor punctuation typo - diagnostic structs: derive on enum (rust-lang#1477) - Update running tests with the new flags (rust-lang#1476) - Rename typeck to hir_analysis (rust-lang#1475) - fix typo and make paragraph consistent (rust-lang#1474) - Update about-this-guide.md - Link to the correct page in "about this guide" - Update r-a config suggestions - don't refer to the compile-time interpreter as "Miri" (rust-lang#1471) - UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558 - Update mdbook and its extensions versions - Remove unmaintained action - Update some actions versions - Fix some typos Update motivated in large part by the most recent commit, to fix `git grep`.
…est-version, r=notriddle Update browser UI test version It added the possibility to concatenate strings and numbers and updated the `goto` command so it doesn't stand on its own anymore. r? ``@notriddle``
rustbot
added
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 8, 2022
@bors r+ rollup=never p=7 |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Oct 8, 2022
⌛ Testing commit 37a23c3 with merge a80d521c1420c81e8e9fd9bf592bb8f6d3c62480... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Oct 8, 2022
bors
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 8, 2022
Likely caused by #101720 |
Yes, thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
mir::CastKind::Misc
#102675 (Removemir::CastKind::Misc
)DefId
from someSelectionCandidate
variants #102785 (RemoveDefId
from someSelectionCandidate
variants)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup