Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic struct for const eval error in rustc_middle #102486

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Add diagnostic struct for const eval error in rustc_middle #102486

merged 1 commit into from
Oct 3, 2022

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Sep 29, 2022 •
edited
Loading

Part of #100717.

r? @ghost

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill force-pushed the middle-const-eval-err branch from 7610599 to 4e58187 Compare September 30, 2022 16:00
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill force-pushed the middle-const-eval-err branch from 4e58187 to 93af6fe Compare October 1, 2022 21:11
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill force-pushed the middle-const-eval-err branch from bb13feb to 70a2950 Compare October 2, 2022 20:57
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Oct 2, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

A change occurred in the Ayu theme.

cc @Cldfire

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in const_evaluatable.rs

cc @lcnr

@pierwill pierwill changed the base branch from master to beta October 2, 2022 21:00
@pierwill pierwill changed the base branch from beta to master October 2, 2022 21:00
@GuillaumeGomez
Copy link
Member

I think you failed a rebase.

@pierwill pierwill force-pushed the middle-const-eval-err branch from 70a2950 to 1295548 Compare October 2, 2022 21:03
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill force-pushed the middle-const-eval-err branch from 1eb61b2 to f04c241 Compare October 3, 2022 02:07
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco reviewed Oct 3, 2022
View reviewed changes
src/test/ui/consts/const_in_pattern/issue-73431.stderr Outdated
@@ -1 +1 @@
WARN rustc_mir_build::thir::pattern::const_to_pat MIR const-checker found novel structural match violation. See #73448.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure :(

@pierwill pierwill force-pushed the middle-const-eval-err branch from f04c241 to d1c83a6 Compare October 3, 2022 15:04
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill requested a review from davidtwco October 3, 2022 17:29
@pierwill
Copy link
Member Author

pierwill commented Oct 3, 2022

I'm stilling getting strange ui test errors locally, but this passes in CI.

@pierwill pierwill force-pushed the middle-const-eval-err branch from f4b87a0 to b9c0467 Compare October 3, 2022 17:30
@compiler-errors
Copy link
Member

@pierwill are you rebased onto the latest master? maybe that's why.

@pierwill
Copy link
Member Author

pierwill commented Oct 3, 2022

@pierwill are you rebased onto the latest master? maybe that's why.

I am. :(

@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 3, 2022

📌 Commit b9c0467 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 3, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 3, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 3, 2022
@matthiaskrgr
Rollup merge of rust-lang#102486 - pierwill:middle-const-eval-err, r=…
a3abc61 
…compiler-errors

Add diagnostic struct for const eval error in `rustc_middle`

Part of rust-lang#100717.

r? `@ghost`
@pierwill
Copy link
Member Author

pierwill commented Oct 3, 2022

@rustbot label -A-bootstrap -A-query-system

@rustbot rustbot removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Oct 3, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 3, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2022
@bors
Auto merge of rust-lang#102632 - matthiaskrgr:rollup-h8s3zmo, r=matth…
f83e026 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#98218 (Document the conditional existence of `alloc::sync` and `alloc::task`.)
 - rust-lang#99216 (docs: be less harsh in wording for Vec::from_raw_parts)
 - rust-lang#99460 (docs: Improve AsRef / AsMut docs on blanket impls)
 - rust-lang#100470 (Tweak `FpCategory` example order.)
 - rust-lang#101040 (Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds)
 - rust-lang#101308 (introduce `{char, u8}::is_ascii_octdigit`)
 - rust-lang#102486 (Add diagnostic struct for const eval error in `rustc_middle`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1b9014f into rust-lang:master Oct 3, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 3, 2022
@pierwill pierwill deleted the middle-const-eval-err branch October 13, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@davidtwco davidtwco Awaiting requested review from davidtwco

Assignees

@compiler-errors compiler-errors

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@pierwill @rustbot @rust-log-analyzer @GuillaumeGomez @compiler-errors @bors @davidtwco