-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use raw-dylib
in the std for non-x86 Windows
#102327
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
This PR does not use |
This is really nice. I kind of expect that this might hit some issues for some users use-cases, but I do think we ultimately want to do this, and this seems like the best way to root out such issues. @bors r+ |
📌 Commit 60a8ff71de494e7c93c5691b79498374c9c33d64 has been approved by It is now in the queue for this repository. |
⌛ Testing commit 60a8ff71de494e7c93c5691b79498374c9c33d64 with merge 8701c58da2bf4e39241e596a4791da07b343617b... |
💔 Test failed - checks-actions |
The error is:
Hm, so this is weird because it's only rust/library/std/src/os/windows/io/socket.rs Lines 202 to 209 in 8b70583
So the test framework loads the std dynamically but I guess cc @dpaoliello |
This comment has been minimized.
This comment has been minimized.
I'm just confirming that I'm right about the issue and checking if there are any other problems. Obviously this commit should not be merged. |
Test successful. Reverting test commit. |
8750a4e
to
4c05e3a
Compare
Interesting - can you please file and issue and assign it to me? I'm on vacation next week but will look into it the week after that. I'm not sure if the best approach will be to have the declaring binary (in this case, std) include the symbol in its normal import library, or if the consuming binary should generate the symbol instead... |
I don't think this is waiting on review, so I'm punting it to the author. That said, maybe S-blocked is more accurate... @rustbot author |
Issue created. This PR is blocked on #102714 so I'll set it to draft. |
This looks great! Thrilled to see that the underlying issue was fixable too! @bors r+ |
Use `raw-dylib` in the std for non-x86 Windows The [`raw_dylib`](rust-lang#58713) feature was recently [stabilized for non-x86 Windows targets](rust-lang#99916). This is now in beta so std start to use it without feature flags. Eventually this may allowing linking Rust programs without needing import libraries. I think the standard library is best placed to dog food before the beta becomes the stable the release. There hopefully shouldn't be any issues but if there are it'd be good to catch them early.
Failed in rollup. #103777 (comment) @bors r- |
4c05e3a
to
d459634
Compare
The Miri subtree was changed cc @rust-lang/miri |
Ok so the miri issue was that we're now importing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a comment nit!
Co-Authored-By: Ralf Jung <[email protected]>
247a271
to
2dc419d
Compare
r=me on the Miri changes. |
☔ The latest upstream changes (presumably #106023) made this pull request unmergeable. Please resolve the merge conflicts. |
Ok, I'm closing this for now. It seems it would be wise to let the I'll keep this branch around for that reason. |
The
raw_dylib
feature was recently stabilized for non-x86 Windows targets. This is now in beta so std start to use it without feature flags. Eventually this may allowing linking Rust programs without needing import libraries.I think the standard library is best placed to dog food before the beta becomes the stable the release. There hopefully shouldn't be any issues but if there are it'd be good to catch them early.