Avoid panicking on missing fallback #101952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mark-Simulacrum: no appropriate reviewer found, use r? to override |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
missing-fallback
branch
from
0153a9e to
8bcbceb
Compare
ehuss
reviewed
Sep 19, 2022
This just prints a message but continues on if a fallback is missing, which can happen when we're building a partial set of builders and producing a dev-static build from it (e.g., when no Apple builder runs at all). Probably the more extensive fix is to allow the build-manifest invoker to specify the expected set of targets & hosts, but that's a far more extensive change. The main risk from this is that we accidentally start falling back to linux docs across all platforms without noticing. I'm not sure that we can do much about that though at this time.
Mark-Simulacrum
force-pushed
the
missing-fallback
branch
from
8bcbceb to
84fb168
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
Rollup of 12 pull requests Successful merges: - rust-lang#101952 (Avoid panicking on missing fallback) - rust-lang#102030 (Don't crate-locally reexport walk functions in tidy) - rust-lang#102032 (Adding ignore fuchsia tests for signal interpretation cases) - rust-lang#102033 (Adding needs-unwind to nicer-assert-messages compiler ui tests) - rust-lang#102054 (Unify "all items" page's sidebar with other pages) - rust-lang#102071 (Adding needs-unwind for tests testing memory size of Futures/Closures) - rust-lang#102073 (Adding ignore fuchsia tests for execvp) - rust-lang#102075 (rustdoc: remove no-op CSS `.content > .methods > .method`) - rust-lang#102079 (Update books) - rust-lang#102084 (Adding needs-unwind for test using panic::catch_unwind) - rust-lang#102100 (Prevent usage of .stab elements to create scrollable areas in doc blocks) - rust-lang#102102 (Add doc aliases on Sized trait) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just prints a message but continues on if a fallback is missing, which can happen when we're building a partial set of builders and producing a dev-static build from it (e.g., when no Apple builder runs at all).
Probably the more extensive fix is to allow the build-manifest invoker to specify the expected set of targets & hosts, but that's a far more extensive change. The main risk from this is that we accidentally start falling back to linux docs across all platforms without noticing. I'm not sure that we can do much about that though at this time.
cc @ehuss since IIRC you participated in adding this system
This comes up when building a test nightly from a try build, e.g., #101855 (comment). For now I'm going to manually cherry pick this onto that PR for testing purposes.