Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only specify --target by default for -Zgcc-ld=lld on wasm #101792

Merged
merged 1 commit into from
Jan 3, 2023

Commits on Jan 2, 2023

  1. only specify --target by default for -Zgcc-ld=lld on wasm

    On macOS, it's not yet clear which cases of clang/OS/target/SDK version impact
    how to find ld/lld/rust-lld. The --target is not needed on our current targets with
    a vanilla config, but may be in some cases. Specifying it all the time breaks the 10.7+
    targets on x64 macOS.
    
    We try to only specify it on macOS if the linker flavors are different,
    for possible cases of cross-compilation with `-Zgcc-ld=lld` but the
    expectation is that it should be passed manually when needed in these
    situations.
    lqd committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    7770b06 View commit details
    Browse the repository at this point in the history