Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a platform support document for Android #101780

Merged
merged 3 commits into from
Sep 24, 2022

Conversation

chriswailes
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2022
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

src/doc/rustc/src/platform-support/android.md Outdated Show resolved Hide resolved
@sanxiyn
Copy link
Member

sanxiyn commented Sep 20, 2022

You also need to edit SUMMARY.md (for mdBook) and platform-support.md (for links). See #92098 for an example.

@chriswailes
Copy link
Contributor Author

You also need to edit SUMMARY.md (for mdBook) and platform-support.md (for links). See #92098 for an example.

Thanks for pointing that out.

@chriswailes
Copy link
Contributor Author

The NDK update policy language in this document is based on discussions held on Zulip and in-person at RustConf with Josh Triplett.

@joshtriplett
Copy link
Member

@bors delegate+

@bors
Copy link
Contributor

bors commented Sep 23, 2022

✌️ @chriswailes can now approve this pull request

@jyn514
Copy link
Member

jyn514 commented Sep 24, 2022

@bors r=joshtriplett rollup

@bors
Copy link
Contributor

bors commented Sep 24, 2022

📌 Commit 7ad0ac7 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 24, 2022
…shtriplett

Add a platform support document for Android

r? `@joshtriplett`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#101780 (Add a platform support document for Android)
 - rust-lang#102044 (Remove `RtlGenRandom` (take two))
 - rust-lang#102081 (Adding ignore fuchsia tests for execvp (pre_exec))
 - rust-lang#102082 (Adding ignore fuchsia non-applicable commands)
 - rust-lang#102146 (rustdoc: CSS prevent sidebar width change jank)
 - rust-lang#102152 (Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly)
 - rust-lang#102175 (Also require other subtrees to always build successfully)
 - rust-lang#102176 (Add `llvm-dis` to the set of tools in `ci-llvm`)
 - rust-lang#102188 (Update doc after renaming `fn is_zero`)
 - rust-lang#102199 (Improve rustdoc GUI tests)
 - rust-lang#102218 (Document some missing command-line arguments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6fff4d9 into rust-lang:master Sep 24, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 24, 2022
@bors
Copy link
Contributor

bors commented Sep 24, 2022

☔ The latest upstream changes (presumably #102223) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants