Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify visitors more #101709

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Simplify visitors more #101709

merged 6 commits into from
Sep 14, 2022

Commits on Sep 12, 2022

  1. Remove path_span argument to the visit_path_segment methods. 

    The `visit_path_segment` method of both the AST and HIR visitors has a
`path_span` argument that isn't necessary. This commit removes it.

There are two very small and inconsequential functional changes.

- One call to `NodeCollector::insert` now is passed a path segment
  identifier span instead of a full path span. This span is only used in
a panic message printed in the case of an internal compiler bug.

- Likewise, one call to `LifetimeCollectVisitor::record_elided_anchor`
  now uses a path segment identifier span instead of a full path span.
  This span is used to make some `'_` lifetimes.
    @nnethercote
    nnethercote committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6568ef3 View commit details
    Browse the repository at this point in the history

  2. Remove unused span argument from walk_fn.

    @nnethercote
    nnethercote committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    925363f View commit details
    Browse the repository at this point in the history

  3. Remove unused span argument from check_mod and process_mod.

    @nnethercote
    nnethercote committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    eff1106 View commit details
    Browse the repository at this point in the history

  4. Remove unused span argument from visit_name.

    @nnethercote
    nnethercote committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    9ec5bda View commit details
    Browse the repository at this point in the history

  5. Remove unused argument from visit_poly_trait_ref.

    @nnethercote
    nnethercote committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    7e3fd33 View commit details
    Browse the repository at this point in the history

  6. Remove unused argument from check_mac_def.

    @nnethercote
    nnethercote committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    b8ed1c5 View commit details
    Browse the repository at this point in the history