rustdoc: avoid cleaning modules with duplicate names #101631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
notriddle
force-pushed
the
notriddle/duplicate-module
branch
from
73d6743
to
1f8d552
Compare
This comment has been minimized.
This comment has been minimized.
|
#83872 tried to solve this earlier, and was closed because it regressed some cases that currently work. How does your code handle #83872 (comment) ? |
|
#83872 (comment) isn't affected. If you documented with a current, nightly compiler, it already removes the duplicate and leaves you only with |
GuillaumeGomez
approved these changes
Sep 10, 2022
|
Looks great, thanks! Maybe we should add an explanation about this reexporting shadowing behaviour in the rustdoc book too once it's merged? @bors r6 |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#101578 (remove bound var hack in `resolve`) - rust-lang#101606 (doc: fix minor typo) - rust-lang#101614 (Equate fn outputs when inferring RPITIT hidden types) - rust-lang#101631 (rustdoc: avoid cleaning modules with duplicate names) - rust-lang#101635 (Move `Queries::new` out of the macro) - rust-lang#101641 (Update browser-ui-test version to 0.9.8) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83375