rustdoc: remove unused CSS #search { position: relative }
#101624
Conversation
This was added in 611d0e6, to allow its child `#results` element to be absolutely positioned inside it. The child stopped being absolute in 8c04695. To keep the layout looking the same, the links need to not have `width: 100%` any more, relying instead on the box naturally growing to fit because it has `display: block`.
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
| @@ -977,7 +973,6 @@ so that we can apply CSS-filters to change the arrow color in themes */ | |||
|
|
|||
| .search-results > a { | |||
| display: block; | |||
| width: 100%; | |||
There was a problem hiding this comment.
There is slight display change with this one as the results seem less wide but the result looks good to me so all good.
There was a problem hiding this comment.
Yeah, I cloned the commit when this was introduced, built the ancient version of rustdoc, and tried removing it. The commit — ee7cc63 — that added this rule claims that it fixed a bug, but it never says what the bug was, there's no screenshot, and I can't actually find anything truly broken when I remove it.
There was a problem hiding this comment.
You can see it in the issue linked in the PR: #85544
|
Thanks! r=me once CI pass |
Width changed by 2/4 pixels by b273c75
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#101413 (Use RelocModel::Pic for UEFI targets) - rust-lang#101595 (Fix ICE report flags display.) - rust-lang#101616 (Adapt test for msan message change) - rust-lang#101624 (rustdoc: remove unused CSS `#search { position: relative }`) - rust-lang#101633 (Rustdoc-Json: Correcty handle intra-doc-links to items without HTML page) - rust-lang#101634 (Rustdoc-Json Tests: Use ``@is`` and ``@ismany`` more often.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was added in 611d0e6, to allow its child
#resultselement to be absolutely positioned inside it. The child stopped being absolute in 8c04695.To keep the layout looking the same, the links need to not have
width: 100%any more, relying instead on the box naturally growing to fit because it hasdisplay: block.