Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update miri submodule #101522

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Update miri submodule #101522

merged 1 commit into from
Sep 7, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 7, 2022

fixes #101344

cc @rust-lang/miri

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2022

The Miri submodule was changed

cc @rust-lang/miri

@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 7, 2022

@bors r+ p=1 submodule bump

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit 58286b8f310c4884e250ed622e8678c5f2dff666 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2022
@bors
Copy link
Contributor

bors commented Sep 7, 2022

⌛ Testing commit 58286b8f310c4884e250ed622e8678c5f2dff666 with merge d3f6742fee5850d0cd27c5fa86b5354212d74725...

@bors
Copy link
Contributor

bors commented Sep 7, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 7, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 7, 2022

@bors r+ p=1 submodule bump

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit de1edd5e971aa26eee209e9501024c2086789388 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2022
RalfJung
RalfJung reviewed Sep 7, 2022
View reviewed changes
compiler/rustc_middle/src/mir/mod.rs
debug_assert!(!self.projection[1..].contains(&PlaceElem::Deref));
debug_assert!(
self.projection.is_empty() || !self.projection[1..].contains(&PlaceElem::Deref)
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so that was the actual cause of the strange ICE...
Cc @ouz-a

Copy link
Contributor

@ouz-a ouz-a Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this slipped without causing any issues until now. This should have been the default behavior...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the ui test suite never hits the code path where this is empty.

@RalfJung
Copy link
Member

RalfJung commented Sep 7, 2022

@bors p=4
Miri has been missing for more than a week.

@RalfJung
Copy link
Member

RalfJung commented Sep 7, 2022

Ah dang, #101476 will probably break Miri again...

@bors
Copy link
Contributor

bors commented Sep 7, 2022

⌛ Testing commit de1edd5e971aa26eee209e9501024c2086789388 with merge 6cb0d4da2b5d29683610c9e18106fbb98635a492...

@bors
Copy link
Contributor

bors commented Sep 7, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 7, 2022

ok this is just breakage from my other PR... doing a miri rustup, then refreshing this PR

@oli-obk oli-obk mentioned this pull request Sep 7, 2022
Merged
bors added a commit to rust-lang/miri that referenced this pull request Sep 7, 2022
@bors
Auto merge of #2535 - oli-obk:rustup, r=oli-obk
ef3f649 
Rustup

fix breakage in rust-lang/rust#101522
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 7, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit 419c4e1 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 7, 2022

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2022
@bors
Copy link
Contributor

bors commented Sep 7, 2022

⌛ Testing commit 419c4e1 with merge f91ca28...

@bors
Copy link
Contributor

bors commented Sep 7, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing f91ca28 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2022
@bors bors merged commit f91ca28 into rust-lang:master Sep 7, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #101522!

Tested on commit f91ca28.
Direct link to PR: #101522

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 7, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#101522!
d7b35f8 
Tested on commit rust-lang/rust@f91ca28.
Direct link to PR: <rust-lang/rust#101522>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk).
@rustbot rustbot added this to the 1.65.0 milestone Sep 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f91ca28): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-0.9%, -0.7%] 6
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-0.9%, -0.7%] 6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)		 4.7% [4.7%, 4.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.5% [3.5%, 3.5%] 1

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouz-a ouz-a ouz-a left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#101333
8 participants
@oli-obk @rustbot @bors @rust-log-analyzer @RalfJung @rust-highfive @rust-timer @ouz-a