rustdoc mobile: move notable traits to return type #101494
Conversation
These were originally on the left, but were moved to the return type in c90fb71. The CSS rule for mobile did not get updated at the time, so updating it now.
jsha
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
added
the
S-waiting-on-review
|
Thanks for this fix! Do you have a screenshots too by any chance? Also, could you add a GUI test too please? |
|
Before (https://doc.rust-lang.org/1.63.0/std/string/struct.String.html#method.drain on mobile)
After
I can work on a GUI test to cover notable traits (there isn't one currently). It doesn't make sense to make a negative test for the removed behavior (i.e. test that the icon is not on the left) because there's no reason to believe it will accidentally wind up on the left in the future. |
|
We agree on that. I just wanted to have something to check the position of "i" in both desktop and mobile. I think we currently don't have one. |
|
I'll add the test in another PR. Opening an issue in the meantime. Thanks for working on this! @bors r+ rollup |
bors
added
S-waiting-on-bors
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#101494 (rustdoc mobile: move notable traits to return type) - rust-lang#101813 (Extend CSS check to CSS variables) - rust-lang#101825 (Fix back RPIT changes) - rust-lang#101843 (Suggest associated const for incorrect use of let in traits) - rust-lang#101859 (Slight vertical formatting) - rust-lang#101868 (rustdoc: use more precise URLs for jump-to-definition links) - rust-lang#101877 (rustdoc: remove no-op CSS `.block { padding: 0 }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
These were originally on the left, but were moved to the return type in c90fb71. The CSS rule for mobile did not get updated at the time, so updating it now.
r? @notriddle