Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup for uninitialized stdout #101404

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

joboet
Copy link
Member

@joboet joboet commented Sep 4, 2022

Fixes #101375 by disabling buffering even if the buffer was not initialized yet.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 4, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022
@bors
Copy link
Contributor

bors commented Sep 5, 2022

☔ The latest upstream changes (presumably #100576) made this pull request unmergeable. Please resolve the merge conflicts.

@joboet joboet force-pushed the always_cleanup_stdout branch from fea1fc9 to 774cadf Compare September 5, 2022 07:08
@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@joshtriplett
Copy link
Member

Seems reasonable.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 5, 2022

📌 Commit 774cadf has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 5, 2022
…shtriplett

Fix cleanup for uninitialized stdout

Fixes rust-lang#101375 by disabling buffering even if the buffer was not initialized yet.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Sep 5, 2022
…shtriplett

Fix cleanup for uninitialized stdout

Fixes rust-lang#101375 by disabling buffering even if the buffer was not initialized yet.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#99291 (Add let else drop order tests)
 - rust-lang#101402 (Add a Machine hook for inline assembly)
 - rust-lang#101404 (Fix cleanup for uninitialized stdout)
 - rust-lang#101418 (Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed")
 - rust-lang#101425 (Point at type parameter in plain path expr)
 - rust-lang#101426 (Don't duplicate file descriptors into stdio fds)
 - rust-lang#101447 (Remove generics_def_id_map from the resolver.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ff124c6 into rust-lang:master Sep 6, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 6, 2022
@joboet joboet deleted the always_cleanup_stdout branch September 11, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print! does not work after shutdown if no previous print occurred
5 participants