Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove redundant mobile-sized .source nav:not(.sidebar).sub #101397

Merged

Conversation

notriddle
Copy link
Contributor

It's redundant because there's already a selector .source nav.sub with exactly the same margin-left at line 796.

This selector was added in 1e98fb1, along with an identical desktop selector, but that desktop selector was removed in 6a5f8b1 as part of a larger simplification.

It's redundant because there's already a selector `.source nav.sub` with
exactly the same margin-left at line 796.

This selector was added in 1e98fb1, along
with an identical desktop selector, but that desktop selector was removed in
6a5f8b1 as part of a larger simplification.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 3, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2022
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Sep 3, 2022

📌 Commit 3e743a0 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 4, 2022
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101322 (Fix internal doc link)
 - rust-lang#101385 (updated description of File struct in std::fs)
 - rust-lang#101388 (Don't delay invalid LHS bug unless it will be covered by an error in `check_overloaded_binop`)
 - rust-lang#101394 (Forbid mixing `System` with direct sytem allocator calls)
 - rust-lang#101397 (rustdoc: remove redundant mobile-sized `.source nav:not(.sidebar).sub`)
 - rust-lang#101401 (Make `char::is_lowercase` and `char::is_uppercase` const)
 - rust-lang#101407 (Remove duplicated test (superseeded by search-form-elements.goml))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43a7438 into rust-lang:master Sep 4, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 4, 2022
@notriddle notriddle deleted the notriddle/source-nav-not-sidebar-sub branch September 4, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants