Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #101128

Closed
wants to merge 45 commits into from
Closed

Commits on Jul 6, 2022

  1. socket set_mark addition.

    to be able to set a marker/id on the socket for network filtering
     (iptables/ipfw here) purpose.
    devnexen committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    14d288f View commit details
    Browse the repository at this point in the history
  2. doc additions

    devnexen committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    48ef00e View commit details
    Browse the repository at this point in the history
  3. changes from feedback

    devnexen committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    10f5a19 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Configuration menu
    Copy the full SHA
    f6efb0b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Start uplifting clippy::for_loops_over_fallibles

    I refactored the code:
    - Removed handling of methods, as it felt entirely unnecessary
    - Removed clippy utils (obviously...)
    - Used some shiny compiler features
      (let-else is very handy for lints 👀)
    - I also renamed the lint to `for_loop_over_fallibles` (note: no `s`).
      I'm not sure what's the naming convention here, so maybe I'm wrong.
    WaffleLapkin committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    7b4cd17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    810cf60 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b661157 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7cf94ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    14b8f24 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2bf213b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5128140 View commit details
    Browse the repository at this point in the history
  8. for_loop_over_fallibles: fix suggestion for "remove .next()" case

    if the iterator is used after the loop, we need to use `.by_ref()`
    WaffleLapkin committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    34815a9 View commit details
    Browse the repository at this point in the history
  9. for_loop_over_fallibles: don't use MachineApplicable

    The loop could contain `break;` that won't work with an `if let`
    WaffleLapkin committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    c4ab59e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    41fccb1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    86360f4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d7b8a65 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. remove an infinite loop

    WaffleLapkin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    aed1ae4 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Configuration menu
    Copy the full SHA
    71b8c89 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    313d474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e4f433 View commit details
    Browse the repository at this point in the history
  3. Use GeneratorKind::descr() instead of it's Display impl

    Those are basically the same but the first one seems to fit better
    IntQuant committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    3f6cb47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f50d171 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    74f9973 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    3fae390 View commit details
    Browse the repository at this point in the history
  2. Remove commented lines

    IntQuant authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e1765a9 View commit details
    Browse the repository at this point in the history
  3. translations: rename warn_ to warning

    The macro warn_ was named like that because it the
    keyword warn is a built-in attribute and at the time
    this macro was created the word 'warning' was also
    taken.
    
    However it is no longer the case and we can rename
    warn_ to warning.
    beowolx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    b508b50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4e97626 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4ff5872 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d464d3a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8189a45 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    252c65e View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Configuration menu
    Copy the full SHA
    8bb4b5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b48870b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. Configuration menu
    Copy the full SHA
    9678751 View commit details
    Browse the repository at this point in the history
  2. add UI test for unpretty

    chenyukang committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    2237c6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e005af View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#94890 - marmeladema:ip-addr-try-from-bytes,…

    … r=joshtriplett
    
    Support parsing IP addresses from a byte string
    
    Fixes rust-lang#94821
    
    The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too.
    
    ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~
    
    Switched to an unstable inherent method approach called `parse_ascii` as requested.
    
    cc ``@jyn514``
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    0e8e3ce View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96334 - devnexen:socket_mark, r=dtolnay

    socket `set_mark` addition.
    
    to be able to set a marker/id on the socket for network filtering
     (iptables/ipfw here) purpose.
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    af4cb05 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#99027 - tmiasko:basic-blocks, r=oli-obk

    Replace `Body::basic_blocks()` with field access
    
    Since the refactoring in rust-lang#98930, it is possible to borrow the basic blocks
    independently from other parts of MIR by accessing the `basic_blocks` field
    directly.
    
    Replace unnecessary `Body::basic_blocks()` method with a direct field access,
    which has an additional benefit of borrowing the basic blocks only.
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    54e79af View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#99696 - WaffleLapkin:uplift, r=fee1-dead

    Uplift `clippy::for_loops_over_fallibles` lint into rustc
    
    This PR, as the title suggests, uplifts [`clippy::for_loops_over_fallibles`] lint into rustc. This lint warns for code like this:
    ```rust
    for _ in Some(1) {}
    for _ in Ok::<_, ()>(1) {}
    ```
    i.e. directly iterating over `Option` and `Result` using `for` loop.
    
    There are a number of suggestions that this PR adds (on top of what clippy suggested):
    1. If the argument (? is there a better name for that expression) of a `for` loop is a `.next()` call, then we can suggest removing it (or rather replacing with `.by_ref()` to allow iterator being used later)
       ```rust
        for _ in iter.next() {}
        // turns into
        for _ in iter.by_ref() {}
        ```
    2. (otherwise) We can suggest using `while let`, this is useful for non-iterator, iterator-like things like [async] channels
       ```rust
       for _ in rx.recv() {}
       // turns into
       while let Some(_) = rx.recv() {}
       ```
    3. If the argument type is `Result<impl IntoIterator, _>` and the body has a `Result<_, _>` type, we can suggest using `?`
       ```rust
       for _ in f() {}
       // turns into
       for _ in f()? {}
       ```
    4. To preserve the original behavior and clear intent, we can suggest using `if let`
       ```rust
       for _ in f() {}
       // turns into
       if let Some(_) = f() {}
       ```
    (P.S. `Some` and `Ok` are interchangeable depending on the type)
    
    I still feel that the lint wording/look is somewhat off, so I'll be happy to hear suggestions (on how to improve suggestions :D)!
    
    Resolves rust-lang#99272
    
    [`clippy::for_loops_over_fallibles`]: https://rust-lang.github.io/rust-clippy/master/index.html#for_loops_over_fallibles
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    2fbc9a4 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#100437 - compiler-errors:better-const-misma…

    …tch-err, r=oli-obk
    
    Improve const mismatch `FulfillmentError`
    
    Fixes rust-lang#100414
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    ea2e810 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#100787 - chenyukang:fix-100770-pretty-crash…

    …, r=petrochenkov
    
    Pretty printing give proper error message without panic
    
    Fixes rust-lang#100770
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    3b550b6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…

    …piler-errors
    
    Migrate part of rustc_infer to session diagnostic
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    4da9d76 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#100959 - LuisCardosoOliveira:translation-re…

    …name-attr-warning, r=davidtwco
    
    translations: rename warn_ to warning
    
    ## Description
    
    This MR renames the the macro `warn_` to `warning`.
    
    To give a little bit of context, as [explained](https://rust-lang.zulipchat.com/#narrow/stream/336883-i18n/topic/.23100717.20diag.20translation/near/295074146) by ```@davidtwco``` in the Zulip channel, `warn_`  was named like that because the keyword `warn` is a built-in attribute and at the time this macro was created the word `warning` was also
    taken.
    
    However, it is no longer the case and we can rename `warn_` to `warning`.
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    6b58cf9 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#101116 - GuillaumeGomez:rm-attrs-ty-alias, …

    …r=notriddle
    
    [rustdoc] Remove Attrs type alias
    
    When working on rust-lang#101006, I was quite confused because of this type alias as I'm used to having rustdoc types into `clean/types.rs`. Anyway, considering how few uses of it we have, I simply removed it.
    
    r? `@notriddle`
    Dylan-DPC authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    0359304 View commit details
    Browse the repository at this point in the history