-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #101124
Rollup of 8 pull requests #101124
Commits on Jul 6, 2022
-
to be able to set a marker/id on the socket for network filtering (iptables/ipfw here) purpose.
Configuration menu - View commit details
-
Copy full SHA for 14d288f - Browse repository at this point
Copy the full SHA 14d288fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48ef00e - Browse repository at this point
Copy the full SHA 48ef00eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10f5a19 - Browse repository at this point
Copy the full SHA 10f5a19View commit details
Commits on Jul 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f6efb0b - Browse repository at this point
Copy the full SHA f6efb0bView commit details
Commits on Aug 14, 2022
-
Start uplifting
clippy::for_loops_over_fallibles
I refactored the code: - Removed handling of methods, as it felt entirely unnecessary - Removed clippy utils (obviously...) - Used some shiny compiler features (let-else is very handy for lints 👀) - I also renamed the lint to `for_loop_over_fallibles` (note: no `s`). I'm not sure what's the naming convention here, so maybe I'm wrong.
Configuration menu - View commit details
-
Copy full SHA for 7b4cd17 - Browse repository at this point
Copy the full SHA 7b4cd17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 810cf60 - Browse repository at this point
Copy the full SHA 810cf60View commit details -
Configuration menu - View commit details
-
Copy full SHA for b661157 - Browse repository at this point
Copy the full SHA b661157View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cf94ad - Browse repository at this point
Copy the full SHA 7cf94adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14b8f24 - Browse repository at this point
Copy the full SHA 14b8f24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bf213b - Browse repository at this point
Copy the full SHA 2bf213bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5128140 - Browse repository at this point
Copy the full SHA 5128140View commit details -
for_loop_over_fallibles
: fix suggestion for "remove.next()
" caseif the iterator is used after the loop, we need to use `.by_ref()`
Configuration menu - View commit details
-
Copy full SHA for 34815a9 - Browse repository at this point
Copy the full SHA 34815a9View commit details -
for_loop_over_fallibles
: don't useMachineApplicable
The loop could contain `break;` that won't work with an `if let`
Configuration menu - View commit details
-
Copy full SHA for c4ab59e - Browse repository at this point
Copy the full SHA c4ab59eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41fccb1 - Browse repository at this point
Copy the full SHA 41fccb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86360f4 - Browse repository at this point
Copy the full SHA 86360f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7b8a65 - Browse repository at this point
Copy the full SHA d7b8a65View commit details
Commits on Aug 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for aed1ae4 - Browse repository at this point
Copy the full SHA aed1ae4View commit details
Commits on Aug 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 71b8c89 - Browse repository at this point
Copy the full SHA 71b8c89View commit details
Commits on Aug 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 313d474 - Browse repository at this point
Copy the full SHA 313d474View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e4f433 - Browse repository at this point
Copy the full SHA 7e4f433View commit details -
Use GeneratorKind::descr() instead of it's Display impl
Those are basically the same but the first one seems to fit better
Configuration menu - View commit details
-
Copy full SHA for 3f6cb47 - Browse repository at this point
Copy the full SHA 3f6cb47View commit details -
Configuration menu - View commit details
-
Copy full SHA for f50d171 - Browse repository at this point
Copy the full SHA f50d171View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74f9973 - Browse repository at this point
Copy the full SHA 74f9973View commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3fae390 - Browse repository at this point
Copy the full SHA 3fae390View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1765a9 - Browse repository at this point
Copy the full SHA e1765a9View commit details -
translations: rename warn_ to warning
The macro warn_ was named like that because it the keyword warn is a built-in attribute and at the time this macro was created the word 'warning' was also taken. However it is no longer the case and we can rename warn_ to warning.
Configuration menu - View commit details
-
Copy full SHA for b508b50 - Browse repository at this point
Copy the full SHA b508b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e97626 - Browse repository at this point
Copy the full SHA 4e97626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff5872 - Browse repository at this point
Copy the full SHA 4ff5872View commit details -
Configuration menu - View commit details
-
Copy full SHA for d464d3a - Browse repository at this point
Copy the full SHA d464d3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8189a45 - Browse repository at this point
Copy the full SHA 8189a45View commit details
Commits on Aug 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 252c65e - Browse repository at this point
Copy the full SHA 252c65eView commit details
Commits on Aug 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8bb4b5f - Browse repository at this point
Copy the full SHA 8bb4b5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b48870b - Browse repository at this point
Copy the full SHA b48870bView commit details -
Add
IsTerminal
trait to determine if a descriptor or handle is a te……rminal The UNIX and WASI implementations use `isatty`. The Windows implementation uses the same logic the `atty` crate uses, including the hack needed to detect msys terminals. Implement this trait for `File` and for `Stdin`/`Stdout`/`Stderr` and their locked counterparts on all platforms. On UNIX and WASI, implement it for `BorrowedFd`/`OwnedFd`. On Windows, implement it for `BorrowedHandle`/`OwnedHandle`. Based on rust-lang#91121 Co-authored-by: Matt Wilkinson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 016e874 - Browse repository at this point
Copy the full SHA 016e874View commit details -
Make is_terminal fail fast if a process has no console at all
If a process has no console, it'll have NULL in place of a console handle, so return early with `false` in that case without making any OS calls.
Configuration menu - View commit details
-
Copy full SHA for 489b73b - Browse repository at this point
Copy the full SHA 489b73bView commit details -
Rewrite FILE_NAME_INFO handling to avoid enlarging slice reference
Rather than referencing a slice's pointer and then creating a new slice with a longer length, offset from the base structure pointer instead. This makes some choices of Rust semantics happier.
Configuration menu - View commit details
-
Copy full SHA for d2cceb7 - Browse repository at this point
Copy the full SHA d2cceb7View commit details
Commits on Aug 28, 2022
-
Rollup merge of rust-lang#94890 - marmeladema:ip-addr-try-from-bytes,…
… r=joshtriplett Support parsing IP addresses from a byte string Fixes rust-lang#94821 The goal is to be able to parse addresses from a byte string without requiring to do any utf8 validation. Since internally the parser already works on byte strings, this should be possible and I personally already needed this in the past too. ~~I used the proposed approach from the issue by implementing `TryFrom<&'a [u8]>` for all 6 address types (3 ip address types and 3 socket address types). I believe implementing stable traits for stable types is insta-stable so this will probably need an FCP?~~ Switched to an unstable inherent method approach called `parse_ascii` as requested. cc `@jyn514`
Configuration menu - View commit details
-
Copy full SHA for 47d44b2 - Browse repository at this point
Copy the full SHA 47d44b2View commit details -
Rollup merge of rust-lang#96334 - devnexen:socket_mark, r=dtolnay
socket `set_mark` addition. to be able to set a marker/id on the socket for network filtering (iptables/ipfw here) purpose.
Configuration menu - View commit details
-
Copy full SHA for 2aaad84 - Browse repository at this point
Copy the full SHA 2aaad84View commit details -
Rollup merge of rust-lang#98033 - joshtriplett:is-terminal-fd-handle,…
… r=thomcc Add `IsTerminal` trait to determine if a descriptor or handle is a terminal The UNIX implementation uses `isatty`. The Windows implementation uses the same logic the `atty` crate uses, including the hack needed to detect msys terminals. Implement this trait for `Stdin`/`Stdout`/`Stderr`/`File` on all platforms. On Unix, implement it for `BorrowedFd`/`OwnedFd`. On Windows, implement it for `BorrowedHandle`/`OwnedHandle`. Based on rust-lang#91121 Co-authored-by: Matt Wilkinson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9c23719 - Browse repository at this point
Copy the full SHA 9c23719View commit details -
Rollup merge of rust-lang#99027 - tmiasko:basic-blocks, r=oli-obk
Replace `Body::basic_blocks()` with field access Since the refactoring in rust-lang#98930, it is possible to borrow the basic blocks independently from other parts of MIR by accessing the `basic_blocks` field directly. Replace unnecessary `Body::basic_blocks()` method with a direct field access, which has an additional benefit of borrowing the basic blocks only.
Configuration menu - View commit details
-
Copy full SHA for 0b7d0a3 - Browse repository at this point
Copy the full SHA 0b7d0a3View commit details -
Rollup merge of rust-lang#99696 - WaffleLapkin:uplift, r=fee1-dead
Uplift `clippy::for_loops_over_fallibles` lint into rustc This PR, as the title suggests, uplifts [`clippy::for_loops_over_fallibles`] lint into rustc. This lint warns for code like this: ```rust for _ in Some(1) {} for _ in Ok::<_, ()>(1) {} ``` i.e. directly iterating over `Option` and `Result` using `for` loop. There are a number of suggestions that this PR adds (on top of what clippy suggested): 1. If the argument (? is there a better name for that expression) of a `for` loop is a `.next()` call, then we can suggest removing it (or rather replacing with `.by_ref()` to allow iterator being used later) ```rust for _ in iter.next() {} // turns into for _ in iter.by_ref() {} ``` 2. (otherwise) We can suggest using `while let`, this is useful for non-iterator, iterator-like things like [async] channels ```rust for _ in rx.recv() {} // turns into while let Some(_) = rx.recv() {} ``` 3. If the argument type is `Result<impl IntoIterator, _>` and the body has a `Result<_, _>` type, we can suggest using `?` ```rust for _ in f() {} // turns into for _ in f()? {} ``` 4. To preserve the original behavior and clear intent, we can suggest using `if let` ```rust for _ in f() {} // turns into if let Some(_) = f() {} ``` (P.S. `Some` and `Ok` are interchangeable depending on the type) I still feel that the lint wording/look is somewhat off, so I'll be happy to hear suggestions (on how to improve suggestions :D)! Resolves rust-lang#99272 [`clippy::for_loops_over_fallibles`]: https://rust-lang.github.io/rust-clippy/master/index.html#for_loops_over_fallibles
Configuration menu - View commit details
-
Copy full SHA for c271a20 - Browse repository at this point
Copy the full SHA c271a20View commit details -
Rollup merge of rust-lang#100437 - compiler-errors:better-const-misma…
…tch-err, r=oli-obk Improve const mismatch `FulfillmentError` Fixes rust-lang#100414
Configuration menu - View commit details
-
Copy full SHA for 91de6b6 - Browse repository at this point
Copy the full SHA 91de6b6View commit details -
Rollup merge of rust-lang#100843 - IntQuant:issue-100717-infer, r=com…
…piler-errors Migrate part of rustc_infer to session diagnostic
Configuration menu - View commit details
-
Copy full SHA for 1e2f33c - Browse repository at this point
Copy the full SHA 1e2f33cView commit details -
Rollup merge of rust-lang#100959 - LuisCardosoOliveira:translation-re…
…name-attr-warning, r=davidtwco translations: rename warn_ to warning ## Description This MR renames the the macro `warn_` to `warning`. To give a little bit of context, as [explained](https://rust-lang.zulipchat.com/#narrow/stream/336883-i18n/topic/.23100717.20diag.20translation/near/295074146) by ``@davidtwco`` in the Zulip channel, `warn_` was named like that because the keyword `warn` is a built-in attribute and at the time this macro was created the word `warning` was also taken. However, it is no longer the case and we can rename `warn_` to `warning`.
Configuration menu - View commit details
-
Copy full SHA for d3725c2 - Browse repository at this point
Copy the full SHA d3725c2View commit details