Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_analysis: Migrate diagnostic #100780

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

wonchulee
Copy link
Contributor

  • Migrate the rustc_save_analysis crate's diagnostic to translatable diagnostic structs.

Depends on #100694 and #100754 for #[fatal(..)] support, then aa68eb4, f5219a3, 7da52f6 can be removed. (I copied commits from #100754)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Aug 19, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
@wonchulee wonchulee changed the title save_analysis: Miggrate diagnostic save_analysis: Migrate diagnostic Aug 19, 2022
@lcnr
Copy link
Contributor

lcnr commented Aug 20, 2022

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned lcnr Aug 20, 2022
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! r=me once all the dependencies have landed and those commits are removed, etc, etc.

@bors

This comment was marked as resolved.

@davidtwco
Copy link
Member

fatal support has landed now, so you should be able to rebase and continue to work on this :)

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
@davidtwco davidtwco mentioned this pull request Aug 23, 2022
84 tasks
wonchulee and others added 2 commits August 24, 2022 06:50
Add impls of `IntoDiagnosticArg` for `std::io::Error`, `std::path::Path`
and `std::path::PathBuf`.

Signed-off-by: David Wood <[email protected]>
@wonchulee wonchulee force-pushed the translation_save_analysis branch from 99fc892 to c18503f Compare August 23, 2022 21:52
@wonchulee
Copy link
Contributor Author

rebased on top of latest master branch, note that it still depends on e6a3632 commit in the #100754 PR.

@davidtwco
Copy link
Member

rebased on top of latest master branch, note that it still depends on e6a3632 commit in the #100754 PR.

That's okay, I'll approve this and if it lands first then I'll rebase otherwise you can :)

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2022

📌 Commit c18503f has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2022
…s, r=davidtwco

save_analysis: Migrate diagnostic

* Migrate the `rustc_save_analysis` crate's diagnostic to translatable diagnostic structs.

Depends on rust-lang#100694 and rust-lang#100754 for #[fatal(..)] support, then rust-lang@aa68eb4, rust-lang@f5219a3, rust-lang@7da52f6 can be removed. (I copied commits from rust-lang#100754)
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`)
 - rust-lang#99954 (let-else: break out to one scope higher for let-else)
 - rust-lang#100188 (Parser will not suggest invalid expression when use public)
 - rust-lang#100780 (save_analysis: Migrate diagnostic)
 - rust-lang#100808 (Migrate `rustc_interface` diagnostics )
 - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated)
 - rust-lang#100960 (rustdoc: ayu code color selector more specific)
 - rust-lang#100964 (Sync rustc_codegen_cranelift)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2e4760c into rust-lang:master Aug 25, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants