-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rustdoc] Fix item info display #100718
Merged
Merged
[rustdoc] Fix item info display #100718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
A-rustdoc-ui
Area: Rustdoc UI (generated HTML)
labels
Aug 18, 2022
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 18, 2022
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-item-info
branch
from
August 18, 2022 14:16
05b7ce8
to
fe6956b
Compare
Fixed fmt too. |
This comment has been minimized.
This comment has been minimized.
And updated tests. |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 20, 2022
[rustdoc] Fix item info display Fixes rust-lang#100369. The solution I came up with was simply to wrap the "text part" of the `item-info` into another span so that `flex` wouldn't mess with it. Live demo is [here](https://rustdoc.crud.net/imperio/fix-item-info/foo/struct.ItemInfo.html). r? `@jsha`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#97963 (net listen backlog set to negative on Linux.) - rust-lang#99935 (Reenable disabled early syntax gates as future-incompatibility lints) - rust-lang#100129 (add miri-test-libstd support to libstd) - rust-lang#100500 (Ban references to `Self` in trait object substs for projection predicates too.) - rust-lang#100636 (Revert "Revert "Allow dynamic linking for iOS/tvOS targets."") - rust-lang#100718 ([rustdoc] Fix item info display) - rust-lang#100769 (Suggest adding a reference to a trait assoc item) - rust-lang#100777 (elaborate how revisions work with FileCheck stuff in src/test/codegen) - rust-lang#100796 (Refactor: remove unnecessary string searchings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rustdoc-ui
Area: Rustdoc UI (generated HTML)
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100369.
The solution I came up with was simply to wrap the "text part" of the
item-info
into another span so thatflex
wouldn't mess with it.Live demo is here.
r? @jsha