-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Machine memory hooks to suggest when they run #100600
Conversation
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
r? @RalfJung |
Uh, what happened with CI? |
r=me when CI is green |
✌️ @saethlin can now approve this pull request |
Hm let's see if I just amend with no changes and force-push... |
1f36517
to
a5cc3a0
Compare
It's a general CI problem currently, nothing wrong with this PR. So I'll just trust that you did a check-build locally... |
Yes the PR passes |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100338 (when there are 3 or more return statements in the loop) - rust-lang#100384 (Add support for generating unique profraw files by default when using `-C instrument-coverage`) - rust-lang#100460 (Update the minimum external LLVM to 13) - rust-lang#100567 (Add missing closing quote) - rust-lang#100590 (Suggest adding an array length if possible) - rust-lang#100600 (Rename Machine memory hooks to suggest when they run) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Rename memory hooks Companion to rust-lang/rust#100600
Some of the other memory hooks start with
before_
orafter_
to indicate that they run before or after a certain operation. These don't, so I was a bit confused as to when they are supposed to run.memory_read
can be read two ways in English, "memory was read" or "this is a memory read" so without the prefix this was especially ambiguous.