-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to generic or arg if it's the self type of unsatisfied projection predicate #100483
Merged
bors
merged 2 commits into
rust-lang:master
from
compiler-errors:point-to-projection-too
Aug 15, 2022
Merged
Point to generic or arg if it's the self type of unsatisfied projection predicate #100483
bors
merged 2 commits into
rust-lang:master
from
compiler-errors:point-to-projection-too
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Aug 13, 2022
r? @spastorino (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 13, 2022
compiler-errors
force-pushed
the
point-to-projection-too
branch
from
August 13, 2022 07:20
d41a24d
to
92185c0
Compare
jyn514
approved these changes
Aug 13, 2022
@bors r=jyn514 |
📌 Commit 92185c0a603735eaebba8c0e286a0af29d84d9fc has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 13, 2022
@bors rollup |
☔ The latest upstream changes (presumably #100511) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Aug 14, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2022
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#99646 (Only point out a single function parameter if we have a single arg incompatibility) - rust-lang#100299 (make `clean::Item::span` return `Option` instead of dummy span) - rust-lang#100335 (Rustdoc-Json: Add `Path` type for traits.) - rust-lang#100367 (Suggest the path separator when a dot is used on a trait) - rust-lang#100431 (Enum variant ctor inherits the stability of the enum variant) - rust-lang#100446 (Suggest removing a semicolon after impl/trait items) - rust-lang#100468 (Use an extensionless `x` script for non-Windows) - rust-lang#100479 (Argument type error improvements) Failed merges: - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate) r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
force-pushed
the
point-to-projection-too
branch
from
August 14, 2022 20:28
92185c0
to
54edf18
Compare
@bors r=jyn514 |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 14, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100211 (Refuse to codegen an upstream static.) - rust-lang#100277 (Simplify format_args builtin macro implementation.) - rust-lang#100483 (Point to generic or arg if it's the self type of unsatisfied projection predicate) - rust-lang#100506 (change `InlineAsmCtxt` to not talk about `FnCtxt`) - rust-lang#100534 (Make code slightly more uniform) - rust-lang#100566 (Use `create_snapshot_for_diagnostic` instead of `clone` for `Parser`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this for
TraitPredicate
s inpoint_at_type_arg_instead_of_call_if_possible
andpoint_at_arg_instead_of_call_if_possible
, so also do it forProjectionPredicate
.Improves spans for a lot of unit tests.