Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename integer log* methods to ilog* #100332

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

eholk
Copy link
Contributor

@eholk eholk commented Aug 9, 2022

This reflects the concensus from the libs team as reported at #70887 (comment).

Joint work with @yoshuawuyts.

This reflects the concensus from the libs team as reported at
rust-lang#70887 (comment)

Co-authored-by: Yosh Wuyts <[email protected]>
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 9, 2022
@rustbot

This comment was marked as resolved.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@yoshuawuyts
Copy link
Member

It seems this needs to be updated to say ilog:

// @has - "$.index[*][?(@.name=='log10')]"
// @!is - "$.index[*][?(@.name=='log10')].crate_id" $local_crate_id

@rust-log-analyzer

This comment has been minimized.

@scottmcm scottmcm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2022
@scottmcm
Copy link
Member

scottmcm commented Aug 9, 2022

The consensus in #70887 (comment) is sufficient libs-api approval for this in nightly, so

r? @scottmcm
@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2022

📌 Commit 0fd4db3 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2022
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99573 (Stabilize backtrace)
 - rust-lang#100069 (Add error if link_ordinal used with unsupported link kind)
 - rust-lang#100086 (Add more `// unit-test`s to MIR opt tests)
 - rust-lang#100332 (Rename integer log* methods to ilog*)
 - rust-lang#100334 (Suggest a missing semicolon before an array)
 - rust-lang#100340 (Iterate generics_def_id_map in reverse order to fix P-critical issue)
 - rust-lang#100345 (docs: remove repetition in `is_numeric` function docs)
 - rust-lang#100352 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0cbecda into rust-lang:master Aug 10, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 10, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 13, 2022
…an-DPC

Fix doc of log function

Hi.

I found a forgotten documentation correction in the following pull request.
rust-lang#100332

See also:
rust-lang#70887
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 13, 2022
…an-DPC

Fix doc of log function

Hi.

I found a forgotten documentation correction in the following pull request.
rust-lang#100332

See also:
rust-lang#70887
workingjubilee pushed a commit to tcdi/postgrestd that referenced this pull request Sep 15, 2022
Fix doc of log function

Hi.

I found a forgotten documentation correction in the following pull request.
rust-lang/rust#100332

See also:
rust-lang/rust#70887
mikegerwitz pushed a commit to lovullo/tame that referenced this pull request Nov 11, 2022
rust-lang/rust#100332

The above MR replaces `log10` and friends with `ilog10`; this is the first
time an unstable feature bit us in a substantially backwards-incompatible
way that's a pain to deal with.

Fortunately, I'm just not going to deal with it: this is used with the
diagnostic system, which isn't yet used by our projects (outside of me
testing), and so those builds shouldn't fail before people upgrade.

This is now pending stabalization with the new name, so hopefully we're good
now:

  rust-lang/rust#70887 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants