Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly forward ByRefSized::fold to the inner iterator #100220

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Aug 7, 2022

cc @timvermeulen, who noticed this mistake in #100214 (comment)

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 7, 2022
@rustbot

This comment was marked as resolved.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2022
@bors
Copy link
Contributor

bors commented Aug 14, 2022

☔ The latest upstream changes (presumably #100525) made this pull request unmergeable. Please resolve the merge conflicts.

@scottmcm
Copy link
Member Author

Conflicts resolved.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2022

📌 Commit 7680c8b has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 23, 2022
…riplett

Properly forward `ByRefSized::fold` to the inner iterator

cc `@timvermeulen,` who noticed this mistake in rust-lang#100214 (comment)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2022
…riplett

Properly forward `ByRefSized::fold` to the inner iterator

cc ``@timvermeulen,`` who noticed this mistake in rust-lang#100214 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 24, 2022
…riplett

Properly forward `ByRefSized::fold` to the inner iterator

cc ```@timvermeulen,``` who noticed this mistake in rust-lang#100214 (comment)
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2022
…iaskrgr

Rollup of 15 pull requests

Successful merges:

 - rust-lang#99993 (linker: Update some outdated comments)
 - rust-lang#100220 (Properly forward `ByRefSized::fold` to the inner iterator)
 - rust-lang#100826 (sugg: take into count the debug formatting)
 - rust-lang#100855 (Extra documentation for new formatting feature)
 - rust-lang#100888 (Coherence negative impls implied bounds)
 - rust-lang#100901 (Make some methods private)
 - rust-lang#100906 (Suggest alternatives when trying to mutate a `HashMap`/`BTreeMap` via indexing)
 - rust-lang#100912 (Diagnose missing includes in run-make tests)
 - rust-lang#100919 (Use par_body_owners for liveness)
 - rust-lang#100922 (Rewrite error index generator to greatly reduce the size of the pages)
 - rust-lang#100926 (Update README.md)
 - rust-lang#100930 (Use `--userns=keep-id` when "docker" is really podman)
 - rust-lang#100938 (rustdoc: remove unused CSS rule)
 - rust-lang#100940 (Do not suggest adding a bound to a opaque type)
 - rust-lang#100945 (Add a missing test case for impl generic mismatch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6deca5f into rust-lang:master Aug 24, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 24, 2022
@scottmcm scottmcm deleted the fix-by-ref-sized branch August 24, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants