Revive suggestions for boxed trait objects instead of impl Trait #100019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
TaKO8Ki
changed the title
TaKO8Ki
changed the title
|
☔ The latest upstream changes (presumably #100024) made this pull request unmergeable. Please resolve the merge conflicts. |
TaKO8Ki
force-pushed
the
suggest-boxed-trait-objects-instead-of-impl-trait
branch
from
719a1a1 to
d90a715
Compare
|
☔ The latest upstream changes (presumably #100213) made this pull request unmergeable. Please resolve the merge conflicts. |
TaKO8Ki
force-pushed
the
suggest-boxed-trait-objects-instead-of-impl-trait
branch
from
d90a715 to
82f2c08
Compare
|
r? @rust-lang/wg-diagnostics |
|
@TaKO8Ki it has only been 6 days since you've submitted this PR, so please wait a bit longer before requesting a new reviewer 😅 |
|
@compiler-errors I had a conflict and requested a review, but as you said, I'll wait a little longer. |
|
r? is to get a new reviewer, not to signal that the PR is ready for a review. But since I already am notified for this, I can take a look later today after a flight. |
|
Looks good! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100019 (Revive suggestions for boxed trait objects instead of impl Trait) - rust-lang#100038 (Document the `no-std` target option in config.toml.example) - rust-lang#100194 (Remove even more box syntax uses from src/test) - rust-lang#100206 (test: skip terminfo parsing in Miri) - rust-lang#100230 (Use start_point instead of next_point to point to elided lifetime amp…) - rust-lang#100244 (Add armv4t-none-eabi take2) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestion implemented in #75608 was not working properly, so I fixed it.