Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.62.0 build on Solaris fails with - error: -Csplit-debuginfo is unstable on this platfor #99208

Closed
psumbera opened this issue Jul 13, 2022 · 3 comments · Fixed by #99236
Closed
Labels
C-bug Category: This is a bug. O-solaris Operating system: Solaris P-high High priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another.

Comments

@psumbera
Copy link
Contributor

While building Rust 1.62.0 on Solaris SPARC it fails with:

Building stage0 tool unstable-book-gen (sparcv9-sun-solaris)
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /builds/psumbera/RUST/solaris-userland/components/rust/rustc/rustc-1.62.0-src/src/tools/rls/racer/Cargo.toml
workspace: /builds/psumbera/RUST/solaris-userland/components/rust/rustc/rustc-1.62.0-src/Cargo.toml
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/builds/psumbera/RUST/solaris-userland/components/rust/rustc/build/sparcv9/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names --cfg=bootstrap -Csymbol-mangling-version=v0 -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Ztls-model=initial-exec --target sparcv9-sun-solaris --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: `-Csplit-debuginfo` is unstable on this platform

Build completed unsuccessfully in 0:00:03
@psumbera psumbera added the C-bug Category: This is a bug. label Jul 13, 2022
@ehuss
Copy link
Contributor

ehuss commented Jul 13, 2022

Looks like this was caused by #95612 (cc @davidtwco). It looks like that also caused issues with openbsd (#96597), I'm wondering if it would make sense to audit which platforms were affected to make sure they are all addressed?

Passing -Zunstable-options seems like a somewhat blunt solution. I would expect it to not pass -Csplit-debuginfo if the target does not support it and the user did not specify it. That is roughly what Cargo does, though I suspect that might be not as easy to do in bootstrap.

@ehuss ehuss added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Jul 13, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 13, 2022
@ehuss ehuss added the O-solaris Operating system: Solaris label Jul 13, 2022
@davidtwco
Copy link
Member

Looks like this was caused by #95612 (cc @davidtwco). It looks like that also caused issues with openbsd (#96597), I'm wondering if it would make sense to audit which platforms were affected to make sure they are all addressed?

Passing -Zunstable-options seems like a somewhat blunt solution. I would expect it to not pass -Csplit-debuginfo if the target does not support it and the user did not specify it. That is roughly what Cargo does, though I suspect that might be not as easy to do in bootstrap.

I'm not sure there's a great way of solving this properly in bootstrap. It should be solved for good by #98051 but if you want to submit a PR in the meantime that adds a condition for Solaris then I can r+ it.

@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-high

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jul 13, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jul 14, 2022
@bors bors closed this as completed in 1e64a7b Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-solaris Operating system: Solaris P-high High priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants