Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: blanket impl is not listed if trait is reexported from a private module #94183

Closed
Xiretza opened this issue Feb 20, 2022 · 0 comments · Fixed by #110533
Closed

rustdoc: blanket impl is not listed if trait is reexported from a private module #94183

Xiretza opened this issue Feb 20, 2022 · 0 comments · Fixed by #110533
Labels
A-synthetic-impls Area: Synthetic impls, used by rustdoc to document auto traits and traits with blanket impls C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Xiretza
Copy link
Contributor

Xiretza commented Feb 20, 2022

I tried this code:

mod actual_sub {
    pub trait Actual {}
}
pub use actual_sub::Actual;

impl<T> Actual for T {}

pub struct S;

I expected to see this happen: the documentation for S shows that it implements Actual.

Instead, this happened: Actual is not listed in the list of blanket impls on S.

If actual_sub is made pub, the Actual blanket impl is now listed in the docs for S.

Meta

rustc --version --verbose:

rustc 1.61.0-nightly (3b348d932 2022-02-19)
binary: rustc
commit-hash: 3b348d932aa5c9884310d025cf7c516023fd0d9a
commit-date: 2022-02-19
host: x86_64-unknown-linux-gnu
release: 1.61.0-nightly
LLVM version: 14.0.0

cc #24305

@Xiretza Xiretza added the C-bug Category: This is a bug. label Feb 20, 2022
@Alexendoo Alexendoo added A-synthetic-impls Area: Synthetic impls, used by rustdoc to document auto traits and traits with blanket impls T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 20, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 19, 2023
@bors bors closed this as completed in 770f6cd Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-synthetic-impls Area: Synthetic impls, used by rustdoc to document auto traits and traits with blanket impls C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants