-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal Compiler Error] occurred when compiling eww with latest nightly build (2022-01-21) #93197
Comments
@Animeshz would you be able to test if #93180 would fix your issue ? (it doesn't seem to fix other similar issues, but maybe it will fix this one), by following these steps:
Thanks in advance. |
@Animeshz PRs are only built on-demand, so either when the bots test and merge it after review, or when someone asks manually for a The latter is what I did here. The bot leaves a comment with the hash when/if the build is successful. In this case it is It would be helpful if you could also try However, it's likely that neither of these will fix the exact issue you're having. Someone has tried them on |
d634ef421795e0140724aa9fddf8137b83e616c9 didn't worked unfortunately, I'll try to find |
Okay, so the area of problem is shorten down, and it exactly happens when there's a Result unwrapping at here, i.e.:
|
This however works fine: match evt_send.send(app::DaemonCommand::NoOp) {
Ok(v) => v,
Err(e) => {
return Err(e);
}
} compiler/rustc_ast_lowering/src/expr.rs:1431 might have some significance in this issue 👀 (I guess?). |
Hey Cleanup Crew ICE-breakers! This bug has been identified as a good cc @AminArria @ayazhafiz @camelid @chrissimpkins @contrun @elshize @h-michael @HallerPatrick @hdhoang @hellow554 @henryboisdequin @imtsuki @JamesPatrickGill @kanru @KarlK90 @matheus-consoli @mental32 @nmccarty @Noah-Kennedy @pard68 @PeytonT @pierreN @Redblueflame @RobbieClarken @RobertoSnap @robjtede @SarthakSingh31 @shekohex @sinato @smmalis37 @steffahn @Stupremee @tamuhey @turboladen @woshilapin @yerke |
Here we go: unwrap-ice-repro.zip |
That's a great first step, thanks. It still relies on |
@rustbot claim |
Taking some time to look closer at this now. It looks like where this is crashing is not covered by #93165, so I will work on a proper fix or disabling PR. |
The previous PR, rust-lang#93165, still performed the drop range analysis despite ignoring the results. Unfortunately, there were ICEs in the analysis as well, so some packages failed to build (see the issue rust-lang#93197 for an example). This change further disables the analysis and just provides dummy results in that case.
I haven't gotten as much time to look into this today as I'd hope, but I did at least prepare a PR that disables the drop range analysis (#93284) and I've confirmed that eww builds with that change. |
@eholk please add this testcase to your PR: #![feature(try_blocks)]
use std::sync::{mpsc, mpsc::SendError};
pub async fn foo() {
let (tx, _) = mpsc::channel();
let _: Result<(), SendError<&str>> = try { tx.send("hello")?; };
}
fn main() {} This also panics on stable. Feel free to add the |
…pnkfelix Disable drop range analysis The previous PR, rust-lang#93165, still performed the drop range analysis despite ignoring the results. Unfortunately, there were ICEs in the analysis as well, so some packages failed to build (see the issue rust-lang#93197 for an example). This change further disables the analysis and just provides dummy results in that case.
Builds fails only with the latest (yesterday released)
rustc 1.60.0-nightly (17d29dcdc 2022-01-21) running on x86_64-unknown-linux-gnu
compiler. Tested with 2022-01-20 compiler and it works all okay!Code
For now: refer to elkowar/eww:crates/eww/src/script_var_handler.rs#L137. I'll update if I'm able to minimize where actually the rustc panics.
<code>
Meta
rustc --version --verbose
:Error output
Backtrace
The text was updated successfully, but these errors were encountered: