Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: fix border-radius and sizing of help and settings icons #93060

Closed
jsha opened this issue Jan 19, 2022 · 1 comment · Fixed by #93113
Closed

rustdoc: fix border-radius and sizing of help and settings icons #93060

jsha opened this issue Jan 19, 2022 · 1 comment · Fixed by #93113
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jan 19, 2022

Currently the help and settings icons next to the search box have a bit of a style mismatch with the search box itself:

image

They have a slightly larger border-radius, and their height is not the same as the search box. We should fix that. We may also want to slightly decrease the height of the search box so the button/icons don't have to get super big to match.
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 19, 2022
@GuillaumeGomez
Copy link
Member

I'll check what I can do.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 20, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 22, 2022
@matthiaskrgr
Rollup merge of rust-lang#93113 - GuillaumeGomez:unify-sizes, r=jsha
e0aa2e6 
Unify search input and buttons size

Fixes rust-lang#93060.

Here what it looks like:

![Screenshot from 2022-01-20 21-38-19](https://user-images.githubusercontent.com/3050060/150418571-fefd6538-b3ee-4dd2-b77b-77e96bcfa0ed.png)
![Screenshot from 2022-01-20 21-38-22](https://user-images.githubusercontent.com/3050060/150418570-53ba259b-9bd4-4084-8b43-d74a5752d712.png)

You can test it [here](https://rustdoc.crud.net/imperio/unify-sizes/std/index.html).

r? `@jsha`
@bors bors closed this as completed in 74b05ce Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify search input and buttons size GuillaumeGomez/rust
2 participants
@jsha @GuillaumeGomez