-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Tracking issue for --no-run
#87022
Comments
( Raised rust-lang/rust#87022 - cargo check should check these.)
This is unrelated to rustdoc. Cargo can do this with |
Oh look, this was already added but without a tracking issue 🤦 I'm going to repurpose this as the tracking issue if you don't mind. #83857 |
--no-run
Please do :-) - Great sluthing btw. Ok so for nightly the cargo issue is unblocked and we should be able to now try and do this. |
( Raised rust-lang/rust#87022 - cargo check should check these.)
( Raised rust-lang/rust#87022 - cargo check should check these.)
|
Are there any blockers to stabilizing this, aside from the naming choice? For what it's worth on that, something like |
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
rustdoc --test --preserve-doctests --no-run
produces empty non-executable files #88110)src/doc/rustdoc
.Unresolved Questions
--no-run
the right name?Implementation history
original issue text
The cargo issue here rust-lang/cargo#6424 points out that we don't have a tracking issue on the librustdoc side for how we can make doc examples compile when we run
cargo check --all-targets
orcargo build --all-targets
. By hook or by crook it would be great to remove this surprising edge case.Also probably even more surprising
cargo test --no-run
also doesn't compile the doc tests.Maybe we need a
cargo test --sligtly-run-doctests
?The text was updated successfully, but these errors were encountered: