Need numeric trait for converting to Option<uint>
#8605
Comments
|
Closing, |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Apr 7, 2022
Remove deps This remove both `regex` and `cargo_metadata` as dependencies making `clippy_dev` compile ~3x faster (~46s -> ~16s locally). `cargo_metadata` was used to extract the `version` field from `Cargo.toml`, which is done trivially without that. `regex` was used to parse `define_clippy_lint` in `update_lints` which is now done using `rustc_lexer`. This isn't any simpler, but it compiles ~15s faster and runs ~3x faster (~2.1s -> ~0.7s locally). The next biggest offenders to compile times are `clap` and `winapi` on windows. `clap` could be removed, but re-implementing enough is probably more work than it's worth. `winapi` is used by `opener` and `walkdir` so it's stuck there. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to implement
size_hint()onRange, we need some numeric trait that covers the ability to convert a given type touint(or more generally,Option<uint>, to cover out of bounds conversions).More specifically, we need to convert the result of
a - bwhereaandbare values of the numeric type. The definition for this conversion touintwould be the number of times that you'd have to addOne::one()to the result to getaback (which is the obvious definition, really).This is needed because
range()doesn't restrict its inputs to primitive numeric types.The text was updated successfully, but these errors were encountered: