rustc_llvm build script breaks when source directory has spaces in filename

[jyn514]

I tried running x check on x86_64-pc-windows-msvc from the directory C:\Users\Joshua Nelson\src\rust

I expected to see this happen: Rust compiles successfully.

Instead, this happened: rustc_llvm fails to build:

  running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.28.29910\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MT" "-O2" "-Brepro" "-IC:\\Users\\Joshua" "Nelson\\src\\rust\\build\\x86_64-pc-windows-msvc\\ci-llvm\\include" "-std:c++14" "/EHs-c-" "/GR-" "-D_CRT_SECURE_NO_DEPRECATE" "-D_CRT_SECURE_NO_WARNINGS" "-D_CRT_NONSTDC_NO_DEPRECATE" "-D_CRT_NONSTDC_NO_WARNINGS" "-D_SCL_SECURE_NO_DEPRECATE" "-D_SCL_SECURE_NO_WARNINGS" "-DUNICODE" "-D_UNICODE" "-D__STDC_CONSTANT_MACROS" "-D__STDC_FORMAT_MACROS" "-D__STDC_LIMIT_MACROS" "-DLLVM_COMPONENT_AARCH64" "-DLLVM_COMPONENT_ARM" "-DLLVM_COMPONENT_ASMPARSER" "-DLLVM_COMPONENT_AVR" "-DLLVM_COMPONENT_BITREADER" "-DLLVM_COMPONENT_BITWRITER" "-DLLVM_COMPONENT_COVERAGE" "-DLLVM_COMPONENT_HEXAGON" "-DLLVM_COMPONENT_INSTRUMENTATION" "-DLLVM_COMPONENT_IPO" "-DLLVM_COMPONENT_LINKER" "-DLLVM_COMPONENT_LTO" "-DLLVM_COMPONENT_MIPS" "-DLLVM_COMPONENT_MSP430" "-DLLVM_COMPONENT_NVPTX" "-DLLVM_COMPONENT_POWERPC" "-DLLVM_COMPONENT_RISCV" "-DLLVM_COMPONENT_SPARC" "-DLLVM_COMPONENT_SYSTEMZ" "-DLLVM_COMPONENT_WEBASSEMBLY" "-DLLVM_COMPONENT_X86" "-DLLVM_RUSTLLVM" "-DNDEBUG" "-FoC:\\Users\\Joshua Nelson\\src\\rust\\build\\x86_64-pc-windows-msvc\\stage0-rustc\\x86_64-pc-windows-msvc\\release\\build\\rustc_llvm-dd01ce8f59e15e73\\out\\llvm-wrapper/PassWrapper.o" "-c" "llvm-wrapper/PassWrapper.cpp"
  cargo:warning=cl : Command line warning D9024 : unrecognized source file type 'Nelson\src\rust\build\x86_64-pc-windows-msvc\ci-llvm\include', object file assumed
  cargo:warning=cl : Command line warning D9027 : source file 'Nelson\src\rust\build\x86_64-pc-windows-msvc\ci-llvm\include' ignored
  PassWrapper.cpp
  C:\Users\Joshua Nelson\src\rust\compiler\rustc_llvm\llvm-wrapper\LLVMWrapper.h(1): fatal error C1083: Cannot open include file: 'llvm-c/BitReader.h': No such file or directory
  exit code: 2

The bug comes from here:

rust/compiler/rustc_llvm/build.rs

Line 122 in 3e99439

for flag in cxxflags.split_whitespace() {

Meta

git merge-base HEAD master: 3e99439

[jyn514]

Hmm it looks like this might actually be an issue with llvm-config? It doesn't have anyway to distinguish spaces:

$ build/x86_64-pc-windows-msvc/ci-llvm//bin/llvm-config.exe --cxxflags
-IC:\Users\Joshua Nelson\src\rust\build\x86_64-pc-windows-msvc\ci-llvm\include -std:c++14   /EHs-c- /GR- -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -DUNICODE -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS

so I think just running that command line on its own is already broken, even without further processing from the build script.

[euclio]

Duplicate of #56650.

[jyn514]

Yup, thanks.