Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parse_sess_created callback to rustc_interface::interface::Config #82900

Closed
ghost opened this issue Mar 8, 2021 · 2 comments · Fixed by #83144
Closed

Add a parse_sess_created callback to rustc_interface::interface::Config #82900

ghost opened this issue Mar 8, 2021 · 2 comments · Fixed by #83144
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@ghost
Copy link

ghost commented Mar 8, 2021

imo this is fine, but we should look into figuring out the story around adding custom things to the depinfo in general. This seems like a larger topic (that may want to include proc macros and similar).

I think we should merge this as it is and then (once clippy is synced into the rustc repo) consider doing a change there that adds a parse_sess_created callback that allows you to modify the session right after it was created.

Originally posted by @oli-obk in rust-lang/rust-clippy#6834 (comment)

cc @flip1995

@rustbot label A-clippy

@rustbot rustbot added the A-clippy Area: Clippy label Mar 8, 2021
@jyn514
Copy link
Member

jyn514 commented Mar 8, 2021

cc #82763 (which has the benefit of being in-tree and can just hardcode the things it wants to do in rustc_session)

@jyn514 jyn514 added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed A-clippy Area: Clippy labels Mar 8, 2021
@ghost
Copy link
Author

ghost commented Mar 15, 2021

once clippy is synced into the rustc repo

It has been synced now.
@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants