Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate whether the atomically()/assert_may_sleep() can be a fail!() instead of rtabort!() #8236

Closed
bblum opened this issue Aug 2, 2013 · 1 comment
Closed

investigate whether the atomically()/assert_may_sleep() can be a fail!() instead of rtabort!() #8236

bblum opened this issue Aug 2, 2013 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Aug 2, 2013

If it is safe to have a task fail when it tries to block in an 'atomically' block, we should prefer to do that instead of rtabort. Then we could add back the test cases that I removed in bc7cee7.
@ghost ghost assigned bblum Aug 2, 2013
@bblum
Copy link
Contributor Author

bblum commented Aug 6, 2013

Nope. Even if I work around the Local::borrow issues, failing at that point will destroy tasks and schedulers improperly in a massive explosion.

@bblum bblum closed this as completed Aug 6, 2013
@bblum bblum removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 13, 2022
@bors
Auto merge of rust-lang#8236 - PatchMixolydic:single_char_lifetime_na…
5991695 
…mes, r=llogiq

new lint: `single_char_lifetime_names`

This pull request adds a lint against single character lifetime names, as they might not divulge enough information about the purpose of the lifetime. This can make code harder to understand. I placed this in `restriction` rather than `pedantic` (as suggested in rust-lang#8233) since most of the Rust ecosystem already uses single character lifetime names (to my knowledge, at least) and since single character lifetime names aren't incorrect. I'd be happy to change this upon request, however. Fixes rust-lang#8233.

- [x] Followed lint naming conventions
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`

changelog: new lint: [`single_char_lifetime_names`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bblum