Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option mutate should return bool #8047

Closed
bblum opened this issue Jul 25, 2013 · 2 comments
Closed

option mutate should return bool #8047

bblum opened this issue Jul 25, 2013 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Jul 25, 2013

No description provided.

@sammykim
Copy link
Contributor

Do you mean if if "is_some" returns true, option mutate returns true? If else, Does it return false?

@bblum
Copy link
Contributor Author

bblum commented Jul 26, 2013

That's right.

@lilyball lilyball mentioned this issue Aug 1, 2013
Closed
@sammykim sammykim mentioned this issue Aug 2, 2013
Closed
lilyball added a commit to lilyball/rust that referenced this issue Aug 2, 2013
@lilyball
option: mutate() and mutate_default() should return bool
e4c4fb1 
Fixes rust-lang#8047.
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 7, 2022
@bors
Auto merge of rust-lang#8646 - Alexendoo:option-as-deref-mut, r=giraf…
650a0e5 
…fate

Fix `as_deref_mut` false positives in `needless_option_as_deref`

Also moves it into `methods/`

Fixes rust-lang#7846
Fixes rust-lang#8047

changelog: [`needless_option_as_deref`]: No longer lints for `as_deref_mut` on Options that cannot be moved

supersedes rust-lang#8064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

option: mutate() and mutate_default() should return bool lilyball/rust
2 participants
@bblum @sammykim