Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for const core::str::from_utf8_unchecked #75196

Closed
3 tasks done
rodrimati1992 opened this issue Aug 5, 2020 · 6 comments · Fixed by #86213
Closed
3 tasks done

Tracking Issue for const core::str::from_utf8_unchecked #75196

rodrimati1992 opened this issue Aug 5, 2020 · 6 comments · Fixed by #86213
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-str Area: str and String C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@rodrimati1992
Copy link
Contributor

rodrimati1992 commented Aug 5, 2020 •
edited
Loading

This is a tracking issue for const fn core::str::from_utf8_unchecked, made const in #75157 .
The feature gate for the issue is #![feature(const_str_from_utf8_unchecked)].

Steps
@rodrimati1992 rodrimati1992 added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Aug 5, 2020
@LeSeulArtichaut LeSeulArtichaut added A-const-fn T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 5, 2020
@KodrAus KodrAus added Libs-Tracked Libs issues that are tracked on the team's project board. A-str Area: str and String labels Aug 6, 2020
@RalfJung
Copy link
Member

RalfJung commented Aug 7, 2020

This is an unsafe operation and thus likely also blocked on rust-lang/const-eval#14.
Cc @rust-lang/wg-const-eval

@m-ou-se
Copy link
Member

m-ou-se commented May 25, 2021

Now that rust-lang/rfcs#3016 is merged:

@rfcbot merge

cc @rust-lang/wg-const-eval

@rfcbot
Copy link

rfcbot commented May 25, 2021 •
edited by yaahc
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 25, 2021
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 3, 2021
@rfcbot
Copy link

rfcbot commented Jun 3, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jun 3, 2021
@jhpratt jhpratt mentioned this issue Jun 11, 2021
Merged
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 13, 2021
@rfcbot
Copy link

rfcbot commented Jun 13, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jun 13, 2021
@jhpratt
Copy link
Member

jhpratt commented Jun 16, 2021

Stabilization PR is already up: #86213

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 17, 2021
@benesch benesch mentioned this issue Jun 18, 2021
Closed
@fee1-dead fee1-dead mentioned this issue Jul 2, 2021
Closed
@bors bors closed this as completed in 308fc23 Jul 4, 2021
@RalfJung RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-str Area: str and String C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize str::from_utf8_unchecked as const jhpratt/rust
8 participants
@RalfJung @m-ou-se @jhpratt @apiraino @KodrAus @rodrimati1992 @rfcbot @LeSeulArtichaut