Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for deque_range #74217

Closed
1 of 2 tasks
jonhoo opened this issue Jul 10, 2020 · 1 comment
Closed
1 of 2 tasks

Tracking Issue for deque_range #74217

jonhoo opened this issue Jul 10, 2020 · 1 comment
Labels
A-collections Area: `std::collection` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@jonhoo
Copy link
Contributor

jonhoo commented Jul 10, 2020

This is a tracking issue for the non-RFC change from #74099, which adds range and range_mut methods to VecDeque.
The feature gate for the issue is #![feature(deque_range)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

@jonhoo jonhoo added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 10, 2020
@jonas-schievink jonas-schievink added A-collections Area: `std::collection` B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 10, 2020
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jul 29, 2020
jonhoo added a commit to jonhoo/left-right that referenced this issue Dec 6, 2020
Keep in mind that since this is a feature, _all_ evmap instances get
amortized if _anything_ in the dependency graph enables the feature
(indexmap-rs/indexmap#137 (comment)).
This is unfortunate, but given that the alternative is forking evmap,
we'll go with the feature approach for now. Hopefully one day we'll have
a way to [avoid this](rust-lang/cargo#2980 (comment)).

Not landing this yet since it's nightly-only at the moment due to
certain methods [in
`atone`](https://github.com/jonhoo/atone/blob/45ae1e42deaaaaa9a919957ade49982a7ac4655b/src/lib.rs#L58).
Nightly-only will go away once
rust-lang/rust#70929 and
rust-lang/rust#74217 both stabilize. The first
one will land on next stable, but the second has some more time to go
first.
jonhoo added a commit to jonhoo/left-right that referenced this issue Dec 17, 2020
Keep in mind that since this is a feature, _all_ evmap instances get
amortized if _anything_ in the dependency graph enables the feature
(indexmap-rs/indexmap#137 (comment)).
This is unfortunate, but given that the alternative is forking evmap,
we'll go with the feature approach for now. Hopefully one day we'll have
a way to [avoid this](rust-lang/cargo#2980 (comment)).

Not landing this yet since it's nightly-only at the moment due to
certain methods [in
`atone`](https://github.com/jonhoo/atone/blob/45ae1e42deaaaaa9a919957ade49982a7ac4655b/src/lib.rs#L58).
Nightly-only will go away once
rust-lang/rust#70929 and
rust-lang/rust#74217 both stabilize. The first
one will land on next stable, but the second has some more time to go
first.
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 26, 2020
…-ou-se

stabilize deque_range

Make rust-lang#74217 stable, stabilizing `VecDeque::range` and `VecDeque::range_mut`.
Pr: rust-lang#74099

r? `@m-ou-se`
@dtolnay
Copy link
Member

dtolnay commented Dec 22, 2021

This was stabilized in #79022 in 1.51.0.

@dtolnay dtolnay closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collections Area: `std::collection` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants