-
Notifications
You must be signed in to change notification settings - Fork 14k
Open
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Description
AFAICT this is the only thing that adds --enable-ninja, and it's Windows-only:
rust/src/ci/scripts/install-ninja.sh
Lines 9 to 16 in b9ac291
| if isWindows; then | |
| mkdir ninja | |
| curl -o ninja.zip "${MIRRORS_BASE}/2017-03-15-ninja-win.zip" | |
| 7z x -oninja ninja.zip | |
| rm ninja.zip | |
| ciCommandSetEnv "RUST_CONFIGURE_ARGS" "${RUST_CONFIGURE_ARGS} --enable-ninja" | |
| ciCommandAddPath "$(pwd)/ninja" | |
| fi |
We also autodetect ninja and use it, but only for MSVC specifically (#43767 / #44084).
On top of being (supposedly) faster than relying on make, IME ninja also has less log spew when building LLVM (but it's unclear if it would help on CI, see #70468).
cc @rust-lang/infra
Metadata
Metadata
Assignees
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.