-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ungreat change to doctest test names #70090
Comments
This comment has been minimized.
This comment has been minimized.
@matthiaskrgr What you're describing is entirely in the opposite direction, |
@ehuss That makes sense, we have a way to get the outermost invocation, that is used by span.ctxt().outer_expn().expansion_cause().unwrap_or(span) We'd just need to use this in |
cc @rust-lang/rustdoc |
Removed |
Well, using what @eddyb suggested seems like the best thing to do. |
Use outermost invocation span for doctest names Fixes rust-lang#70090. This PR also allows using aux-build files in rustdoc-ui tests.
Doctest test names have changed due to #66364. Doc comments that pass through a macro defined in another crate now seem to report a different span.
running with
cargo test --doc
previously looked like this:Now the test names look like this:
Frankly, neither are particularly great. It would be nice if the test name used the span from where the macro was invoked, not where it was defined.
rustc 1.43.0-nightly (c20d7eecb 2020-03-11)
The text was updated successfully, but these errors were encountered: