x.py check --stage 1 silently just checks bootstrap (stage0) compiler #69337
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
jonas-schievink
added
T-bootstrap
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
May 14, 2020
…lexcrichton Forbid stage arguments to check Users generally expect that check builds are fast, and that's only true in stage 0 (stages beyond that need us to build a compiler, which is slow). Closes rust-lang#69337 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
./x.py check --stage 1does not build anything (yay,checkwithout waiting for a build!), which means that it cannot actually be checking the stage1 (post-bootstrap) build, and is instead just silently checking the stage0 (bootstrap) build.This would be most useful with
./x.py check --stage 1 --keep-stage 0, as this would keep this as a check-only build rather than requiring a build of stage 0. This unfortunately can't really be automatic, as changes to the compiler that necessitate acheckrun would prompt a rebuild of stage 0.The text was updated successfully, but these errors were encountered: