Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc-dev component from default profile #67425

Closed
jethrogb opened this issue Dec 19, 2019 · 2 comments · Fixed by #67469
Closed

Remove rustc-dev component from default profile #67425

jethrogb opened this issue Dec 19, 2019 · 2 comments · Fixed by #67469
Labels
T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@jethrogb
Copy link
Contributor

jethrogb commented Dec 19, 2019 •
edited
Loading

The rustc-dev component is larger than all other components of the default profile combined, yet most users probably don't care about this. I think it should be removed.

Perhaps another profile default-poweruser can be made that does include it.
@jethrogb jethrogb changed the title rustc-dev Remove rustc-dev component from default profile Dec 19, 2019
@kinnison
Copy link
Contributor

I'd argue that the complete profile (which is basically rust devs-only anyway) might be an acceptable place for this, without needing to add a new profile name. People who want default plus rustc-dev can just do rustup toolchain install nightly --profile default --component rustc-dev

@Mark-Simulacrum Mark-Simulacrum added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Dec 19, 2019
@Mark-Simulacrum
Copy link
Member

It was the intent when merging the PR that split the rustc-dev profile out that we would eventually remove it from the default set. I believe this is already true on beta (and perhaps stable as of later today?).

I would accept a PR at this point that removes rustc-dev component from the default set on nightly as well.

@cuviper cuviper mentioned this issue Dec 20, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Dec 21, 2019
@Centril
Rollup merge of rust-lang#67469 - cuviper:no-default-rustc-dev, r=Mar…
9f89179 
…k-Simulacrum

Remove rustc-dev from the default nightly components

It was already filtered from other branches, but we only kept it in
nightly's default to ease the transition. Now that the separation of
rust-std/rustc-dev has reached the 1.40 release, it seems like a good
time for that transition to end.

Closes rust-lang#67425.
r? @Mark-Simulacrum
@bors bors closed this as completed in b9a6d74 Dec 22, 2019
@rinon rinon mentioned this issue Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rustc-dev from the default nightly components cuviper/rust
3 participants
@jethrogb @kinnison @Mark-Simulacrum