Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap should be able to learn target information from Rustc target database #67171

Open
jethrogb opened this issue Dec 9, 2019 · 0 comments
Open

Bootstrap should be able to learn target information from Rustc target database #67171

jethrogb opened this issue Dec 9, 2019 · 0 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jethrogb
Copy link
Contributor

jethrogb commented Dec 9, 2019

There is lots of behavior in bootstrap that just does string matching on the target name to partially alter its behavior. A lot of the time, this information could've been determined by looking at a particular target option (from rustc --print=target-spec-json).
@jethrogb jethrogb mentioned this issue Dec 9, 2019
Merged
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 9, 2019
bors added a commit that referenced this issue Dec 12, 2019
@bors
Auto merge of #67172 - jethrogb:jb/bootstrap-linker, r=alexcrichton
3eeb8d4 
Bootstrap: change logic for choosing linker and rpath

This is a follow-up from #66957 and #67023. Apparently there was one more location with a hard-coded list of targets to influence linking.

I've filed #67171 to track this madness.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jethrogb @jonas-schievink