Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated --explain examples for E0659 "An item usage is ambiguous." #65571

Closed
mattheww opened this issue Oct 18, 2019 · 1 comment · Fixed by #65691
Closed

Outdated --explain examples for E0659 "An item usage is ambiguous." #65571

mattheww opened this issue Oct 18, 2019 · 1 comment · Fixed by #65691
Assignees
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-resolve Area: Name resolution

Comments

@mattheww
Copy link
Contributor

See E0659 for the current text.

It includes the following example:

pub mod moon {
    pub fn foo() {}
}

pub mod earth {
    pub fn foo() {}
}

mod collider {
    pub use moon::*;
    pub use earth::*;
}

fn main() {
    collider::foo(); // ERROR: `foo` is ambiguous
}

which needs updating for Rust 2018: it needs crate:: or parent:: adding inside mod collider.

The same is true in the recommended replacement.

@jonas-schievink jonas-schievink added A-resolve Area: Name resolution A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Oct 18, 2019
@Centril
Copy link
Contributor

Centril commented Oct 19, 2019

cc @GuillaumeGomez

@GuillaumeGomez GuillaumeGomez self-assigned this Oct 21, 2019
Centril added a commit to Centril/rust that referenced this issue Oct 23, 2019
…r=Dylan-DPC

Update E0659 error code long explanation to 2018 edition

Fixes rust-lang#65571

r? @Centril
@bors bors closed this as completed in ba9a9eb Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-resolve Area: Name resolution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants