Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cc rust-lang/compiler for toolstate changes #65238

Closed
varkor opened this issue Oct 9, 2019 · 2 comments · Fixed by #65276
Closed

Don't cc rust-lang/compiler for toolstate changes #65238

varkor opened this issue Oct 9, 2019 · 2 comments · Fixed by #65276
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented Oct 9, 2019 •
edited
Loading

While it's important to keep on top of regressions to the toolstate, most of the time these issues are fixed quickly, by the author of the PR that caused the regression, or someone else. With GitHub notifications being difficult enough to keep up with as it is, being mentioned on every toolstate change issue is mostly noise. The issues are already tagged T-compiler and nominated, so I think additionally pinging everyone is unnecessary.

I think it would be sensible to change:

rust/src/tools/publish_toolstate.py

Line 146 in 5283791

cc @{}, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

to:

cc @{}, the PR reviewer, and nominating for compiler team prioritization.

cc @rust-lang/compiler
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 9, 2019
@michaelwoerister
Copy link
Member

I think that's a good idea!

@nikomatsakis
Copy link
Contributor

I agree that the pings are rarely useful. Nominating is probably sufficient.

@varkor varkor mentioned this issue Oct 10, 2019
Merged
tmandry added a commit to tmandry/rust that referenced this issue Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
f1d2d95 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
tmandry added a commit to tmandry/rust that referenced this issue Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
7ed57bb 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
Centril added a commit to Centril/rust that referenced this issue Oct 11, 2019
@Centril
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
d1f1cfd 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
@bors bors closed this as completed in 9917f06 Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't cc rust-lang/compiler for toolstate changes varkor/rust
4 participants
@nikomatsakis @jonas-schievink @michaelwoerister @varkor