Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in derive macros Encodable, Decodable, RustcEncodable and RustcDecodable are stable #62048

Closed
petrochenkov opened this issue Jun 22, 2019 · 4 comments · Fixed by #62507
Closed

Built-in derive macros Encodable, Decodable, RustcEncodable and RustcDecodable are stable #62048

petrochenkov opened this issue Jun 22, 2019 · 4 comments · Fixed by #62507
Assignees
@petrochenkov
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@petrochenkov
Copy link
Contributor

The macros produce paths like serialize::foo or rustc_serialize::foo and I suspect that the feature gating was supposed to happen when you write extern crate serialize to bring that serialize into scope.

However, you can easily write use anything as serialize, and rustc_serialize is a stable crate on crates.io, so this kind of feature gating doesn't work.

After #62042 lands we should try to un-stabilize them and test it with crater.
@jonas-schievink jonas-schievink added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed I-nominated labels Jun 22, 2019
@petrochenkov
Copy link
Contributor Author

The bench attribute macro is also stable.

@pnkfelix
Copy link
Member

pre-triage: P-medium. removing nomination.

@petrochenkov : do you want to be assigned to this? Or are you just sending out a general alert, but do not plan to fix it?

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jun 27, 2019
@petrochenkov
Copy link
Contributor Author

@pnkfelix
I can make a PR for crater once #62042 lands.

@petrochenkov petrochenkov self-assigned this Jul 8, 2019
@petrochenkov petrochenkov mentioned this issue Jul 8, 2019
Merged
bors added a commit that referenced this issue Jul 8, 2019
@bors
Auto merge of #62507 - petrochenkov:macunstab, r=<try>
18481b6 
[WIP] Feature gate `(Rustc){En,De}codable` and `bench` for crater run

cc #62048
r? @ghost
@petrochenkov
Copy link
Contributor Author

PR for crater - #62507.

Centril added a commit to Centril/rust that referenced this issue Jul 29, 2019
@Centril
Rollup merge of rust-lang#62507 - petrochenkov:macunstab, r=alexcrichton
600c8f6 
Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]`

`Encodable` and `Decodable` were deprecated before 1.0 and emitted an unsuppressable warning all this time.
`#[bench]` is a part of the custom test framework feature and cannot be used meaningfully on stable, only as `cfg(false)`.

Crater results can be found in rust-lang#62507 (comment) and below.

This PR also reroutes the tracking issue for `feature(test)` from rust-lang#27812 (compiler internals) to rust-lang#50297 (custom test frameworks).

Closes rust-lang#62048
bors added a commit that referenced this issue Aug 1, 2019
@bors
Auto merge of #62507 - petrochenkov:macunstab, r=alexcrichton
f23a5f2 
Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]`

`Encodable` and `Decodable` were deprecated before 1.0 and emitted an unsuppressable warning all this time.
`#[bench]` is a part of the custom test framework feature and cannot be used meaningfully on stable, only as `cfg(false)`.

Crater results can be found in #62507 (comment) and below.

This PR also reroutes the tracking issue for `feature(test)` from #27812 (compiler internals) to #50297 (custom test frameworks).

Closes #62048
@djrenren djrenren mentioned this issue Aug 22, 2019
Closed
@traviscross traviscross mentioned this issue Apr 10, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrochenkov petrochenkov

Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove derives Encodable/Decodable and unstabilize attribute #[bench] petrochenkov/rust
4 participants
@pnkfelix @Centril @jonas-schievink @petrochenkov