Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CMAKE_INSTALL_MESSAGE to LAZY for code built with CMake, LLVM in particular #60830

Closed
petrochenkov opened this issue May 14, 2019 · 2 comments · Fixed by #60832
Closed

Set CMAKE_INSTALL_MESSAGE to LAZY for code built with CMake, LLVM in particular #60830

petrochenkov opened this issue May 14, 2019 · 2 comments · Fixed by #60832
Labels
P-high High priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@petrochenkov
Copy link
Contributor

The "log is too long" error in #60740 (comment) reminded me about this possibility.

CMAKE_INSTALL_MESSAGE=LAZY will avoid printing installation messages for up-to-date files into the log.
There are many of them in the log as you can see.
@petrochenkov petrochenkov added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels May 14, 2019
@petrochenkov petrochenkov mentioned this issue May 14, 2019
Merged
@pietroalbini pietroalbini added I-nominated T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. P-high High priority and removed I-nominated labels May 14, 2019
@petrochenkov
Copy link
Contributor Author

Ok, since it turned out to be a real problem blocking PRs, I'll try to implement it myself today.

@petrochenkov petrochenkov removed E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels May 14, 2019
@petrochenkov petrochenkov mentioned this issue May 14, 2019
Merged
@petrochenkov
Copy link
Contributor Author

Fixed in #60832

Centril added a commit to Centril/rust that referenced this issue May 15, 2019
@Centril
Rollup merge of rust-lang#60832 - petrochenkov:CLazy, r=Mark-Simulacrum
adb05d1 
CMake: Do not print installation messages for up-to-date files

Closes rust-lang#60830
Centril added a commit to Centril/rust that referenced this issue May 15, 2019
@Centril
Rollup merge of rust-lang#60832 - petrochenkov:CLazy, r=Mark-Simulacrum
566f4a9 
CMake: Do not print installation messages for up-to-date files

Closes rust-lang#60830
bors added a commit that referenced this issue May 15, 2019
@bors
Auto merge of #60832 - petrochenkov:CLazy, r=Mark-Simulacrum
7158ed9 
CMake: Do not print installation messages for up-to-date files

Closes #60830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-high High priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake: Do not print installation messages for up-to-date files petrochenkov/rust
2 participants
@pietroalbini @petrochenkov