async fn should be disallowed entirely on 2015 edition #58652
Labels
A-async-await
Area: Async & Await
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
nikomatsakis
added
T-compiler
|
Note we should also test nested async fn in fns, as described in #51933 |
|
Hello, I'd like to have a go at this |
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 27, 2019
…n, r=varkor
Deny `async fn` in 2015 edition
This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
Compiling code of the form:
```rust
async fn foo() {}
```
Will now result in the error:
```
error[E0670]: `async fn` is not permitted in the 2015 edition
--> async.rs:1:1
|
1 | async fn foo() {}
| ^^^^^
error: aborting due to error
For more information about an error, try `rustc --explain E0670`.
```
This resolves rust-lang#58652 and also resolves rust-lang#53714.
r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 27, 2019
…n, r=varkor
Deny `async fn` in 2015 edition
This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
Compiling code of the form:
```rust
async fn foo() {}
```
Will now result in the error:
```
error[E0670]: `async fn` is not permitted in the 2015 edition
--> async.rs:1:1
|
1 | async fn foo() {}
| ^^^^^
error: aborting due to error
For more information about an error, try `rustc --explain E0670`.
```
This resolves rust-lang#58652 and also resolves rust-lang#53714.
r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 27, 2019
…n, r=varkor
Deny `async fn` in 2015 edition
This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
Compiling code of the form:
```rust
async fn foo() {}
```
Will now result in the error:
```
error[E0670]: `async fn` is not permitted in the 2015 edition
--> async.rs:1:1
|
1 | async fn foo() {}
| ^^^^^
error: aborting due to error
For more information about an error, try `rustc --explain E0670`.
```
This resolves rust-lang#58652 and also resolves rust-lang#53714.
r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 27, 2019
…n, r=varkor
Deny `async fn` in 2015 edition
This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
Compiling code of the form:
```rust
async fn foo() {}
```
Will now result in the error:
```
error[E0670]: `async fn` is not permitted in the 2015 edition
--> async.rs:1:1
|
1 | async fn foo() {}
| ^^^^^
error: aborting due to error
For more information about an error, try `rustc --explain E0670`.
```
This resolves rust-lang#58652 and also resolves rust-lang#53714.
r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 27, 2019
…n, r=varkor
Deny `async fn` in 2015 edition
This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
Compiling code of the form:
```rust
async fn foo() {}
```
Will now result in the error:
```
error[E0670]: `async fn` is not permitted in the 2015 edition
--> async.rs:1:1
|
1 | async fn foo() {}
| ^^^^^
error: aborting due to error
For more information about an error, try `rustc --explain E0670`.
```
This resolves rust-lang#58652 and also resolves rust-lang#53714.
r? @varkor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As described in #53714, we currently permit a small amount of
asyncnotation in 2015, but we can't extend that to the complete feature set (e.g., await keywords etc). This was done as part of a transitionary tactic (so people could move to Rust 2018) but by now that is not necessary. We should just prohibitasync fnin Rust 2015 entirely at this point.The text was updated successfully, but these errors were encountered: