Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc code wrapping is sometimes too eager #58226

Closed
euclio opened this issue Feb 6, 2019 · 0 comments
Closed

rustdoc code wrapping is sometimes too eager #58226

euclio opened this issue Feb 6, 2019 · 0 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@euclio
Copy link
Contributor

euclio commented Feb 6, 2019 •
edited
Loading

Documenting the following file:

use std::fmt::Debug;

pub fn foo() -> impl Debug {}

The source displays as:

screen shot 2019-02-06 at 9 26 51 am

I expected the source to wrap at around 80 characters.

I'm working on a fix.
@jonas-schievink jonas-schievink added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 6, 2019
@euclio euclio mentioned this issue Feb 12, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this issue Feb 20, 2019
@kennytm
Rollup merge of rust-lang#58409 - euclio:impl-trait-wrapping, r=Quiet…
8d1e432 
…Misdreavus

rustdoc: respect alternate flag when formatting impl trait

Fixes rust-lang#58226.

Before:
<img width="963" alt="screen shot 2019-02-12 at 3 23 30 pm" src="https://user-images.githubusercontent.com/1372438/52665732-4496ea00-2eda-11e9-9e29-efffe43b2abf.png">

After:
<img width="964" alt="screen shot 2019-02-12 at 3 23 51 pm" src="https://user-images.githubusercontent.com/1372438/52665733-452f8080-2eda-11e9-999a-dd1fb28dee16.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@euclio @jonas-schievink