Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for unicode case folding #5820

Closed
Kimundi opened this issue Apr 10, 2013 · 1 comment
Closed

Add support for unicode case folding #5820

Kimundi opened this issue Apr 10, 2013 · 1 comment

Comments

@Kimundi
Copy link
Member

Kimundi commented Apr 10, 2013

Currently, core includes no unicode case folding functions.

Full locale-dependent support as explained in http://www.w3.org/International/wiki/Case_folding is probably out of scope for the core library, however, one following a default folding as mentioned in http://www.unicode.org/faq/casemap_charprop.html#5 should probably be included to make working with strings easier.
@graydon
Copy link
Contributor

graydon commented May 30, 2013

dupe of #1347

@graydon graydon closed this as completed May 30, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2020
@bors
Auto merge of rust-lang#5820 - ThibsG:FixSuspiciousArithmeticImpl, r=…
f5d429c 
…flip1995

Fix FP for `suspicious_arithmetic_impl` from `suspicious_trait_impl` …

As discussed in rust-lang#3215, the `suspicious_trait_impl` lint causes too many false positives, as it is complex to find out if binary operations are suspicious or not.

This PR restricts the number of binary operations to at most one, otherwise we don't lint.
This can be seen as very conservative, but at least FP can be reduced to bare minimum.

Fixes: rust-lang#3215

changelog: limit the `suspicious_arithmetic_impl` lint to one binop, to avoid many FPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @Kimundi