Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustdoc/nightly] can not toggle source sidebar #57601

Closed
joekyo opened this issue Jan 14, 2019 · 3 comments
Closed

[rustdoc/nightly] can not toggle source sidebar #57601

joekyo opened this issue Jan 14, 2019 · 3 comments
Assignees
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@joekyo
Copy link

joekyo commented Jan 14, 2019

In nightly channel, the source code html pages generated by rustdoc has an icon at the left upper corner > , which can be used for toggling a list of the source files and it is quite handy.
The problem is that in the recent nightly version of rustdoc, maybe starting from January this year, the toggle icon is still there, but it doesn't work anymore. When it is clicked, the file list doesn't show up.
As I remember it can work in December last year, e.g. in nightly-2018-12-18 it works.

@joekyo joekyo changed the title [rustdoc/nightly] files navigator does not work [rustdoc/nightly] files navigator does not show up Jan 14, 2019
@joekyo
Copy link
Author

joekyo commented Jan 14, 2019

Looks like the lack of <div id="source_sidebar">...</div> causes this problem.

@joekyo joekyo changed the title [rustdoc/nightly] files navigator does not show up [rustdoc/nightly] can not toggle source sidebar Jan 14, 2019
@Centril Centril added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 15, 2019
@joekyo
Copy link
Author

joekyo commented Jan 15, 2019

cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Good catch! Will fix as soon as possible.

@GuillaumeGomez GuillaumeGomez self-assigned this Jan 15, 2019
Centril added a commit to Centril/rust that referenced this issue Jan 17, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 17, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 17, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 18, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
… r=QuietMisdreavus

Fix sources sidebar not showing up

Fixes rust-lang#57601.

The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants