Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup: nightly 2018-12-25 fails to install #57111

Closed
matthiaskrgr opened this issue Dec 25, 2018 · 12 comments · Fixed by #57116
Closed

rustup: nightly 2018-12-25 fails to install #57111

matthiaskrgr opened this issue Dec 25, 2018 · 12 comments · Fixed by #57116
Labels
O-linux Operating system: Linux O-macos Operating system: macOS P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 25, 2018

Looks like I'm not getting a new nightly for Christmas 😢

rustup update

info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'beta-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2018-12-25, rust version 1.33.0-nightly (f960f377f 2018-12-24)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: downloading component 'rls'
info: downloading component 'clippy'
info: downloading component 'llvm-tools-preview'
info: downloading component 'rust-analysis'
info: downloading component 'rust-src'
info: downloading component 'rustfmt'
info: removing component 'rustc'
info: removing component 'rust-std'
info: removing component 'cargo'
info: removing component 'rust-docs'
info: removing component 'rls'
info: removing component 'clippy'
info: removing component 'llvm-tools-preview'
info: removing component 'rust-analysis'
info: removing component 'rust-src'
info: removing component 'rustfmt'
info: installing component 'rustc'
info: installing component 'rust-std'
info: rolling back changes
error: could not rename component file from '/home/matthias/.rustup/tmp/ronagpiu3nt6eloc_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share'
error: could not rename component file from '/home/matthias/.rustup/tmp/9k8l7uv_ss553dk5_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc'
error: could not rename component file from '/home/matthias/.rustup/tmp/ki2c_xzhvwcjkabo_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu'
error: could not rename component file from '/home/matthias/.rustup/tmp/odxfao3_dovk8n4q_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/man'
error: failed to install component: 'rust-std-x86_64-unknown-linux-gnu', detected conflict: '"lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM-8svn.so"'
info: checking for self-updates

       stable-x86_64-unknown-linux-gnu unchanged - rustc 1.31.1 (b6c32da9b 2018-12-18)
         beta-x86_64-unknown-linux-gnu unchanged - rustc 1.32.0-beta.6 (a01b0bf0f 2018-12-19)
  nightly-x86_64-unknown-linux-gnu update failed - rustc 1.33.0-nightly (2d3e909e4 2018-12-22)

@matthiaskrgr
Copy link
Member Author

I checked verbose mode but didnt see anything interesting, just a ton of
verbose: creating temp {file,directory}

@matthiaskrgr matthiaskrgr changed the title nightly 2018-12-25 fails to install rustup: nightly 2018-12-25 fails to install Dec 25, 2018
@matthiaskrgr
Copy link
Member Author

This also reproduces on travis ci: https://travis-ci.org/matthiaskrgr/cargo-cache/jobs/471994137#L434

@Mark-Simulacrum
Copy link
Member

cc @rust-lang/infra @rust-lang/dev-tools @pietroalbini @kennytm

@Mark-Simulacrum Mark-Simulacrum added P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 25, 2018
@ishitatsuyuki
Copy link
Contributor

#56944 seems the most relevant. cc @alexcrichton

@retep998 retep998 added the O-linux Operating system: Linux label Dec 25, 2018
@retep998
Copy link
Member

Windows appears to be unaffected.

@kennytm
Copy link
Member

kennytm commented Dec 25, 2018

PRs involved: ddab10a...f960f37

Failed to install on macOS too.

@kennytm kennytm added the O-macos Operating system: macOS label Dec 25, 2018
@alexcrichton
Copy link
Member

I'm about 95% sure that this is #56944. It's fine to revert it quickly as I won't have time to make a fix until 2019!

@DanB91
Copy link

DanB91 commented Dec 25, 2018

Hi I am still getting this error on macOS. I uninstalled all of my rust toolchains, so this nightly install would be in the only toolchain on my system. Should we reopen this bug? Error message:

➜  rust git:(master) ✗ rustup install nightly
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: latest update on 2018-12-25, rust version 1.33.0-nightly (f960f377f 2018-12-24)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: installing component 'rustc'
info: installing component 'rust-std'
info: rolling back changes
error: failed to install component: 'rust-std-x86_64-apple-darwin', detected conflict: '"lib/rustlib/x86_64-apple-darwin/lib/libLLVM.dylib"'

@pietroalbini
Copy link
Member

This will be fixed on tomorrow's nightly (released around midnight UTC).

@mcandre
Copy link

mcandre commented Dec 25, 2018

Ay can we add a rustup installation test so that this is caught before uploading?

@MasterDeflate
Copy link

MasterDeflate commented Dec 25, 2018

Still not fixed there still issues?

#  rustup install nightly
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2018-12-25, rust version 1.33.0-nightly (f960f377f 2018-12-24)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: installing component 'rustc'
info: installing component 'rust-std'
info: rolling back changes
error: failed to install component: 'rust-std-x86_64-unknown-linux-gnu', detected conflict: '"lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM-8svn.so"'

@matthiaskrgr
Copy link
Member Author

I was able to successfully update now! :)

info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'beta-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2018-12-26, rust version 1.33.0-nightly (14b96659e 2018-12-25)
info: downloading component 'rustc'
 81.9 MiB /  81.9 MiB (100 %)   1.1 MiB/s ETA:   0 s
info: downloading component 'rust-std'
 56.8 MiB /  56.8 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: downloading component 'cargo'
  4.4 MiB /   4.4 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: downloading component 'rust-docs'
  8.6 MiB /   8.6 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: downloading component 'rls'
  6.7 MiB /   6.7 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: downloading component 'clippy'
  1.8 MiB /   1.8 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: downloading component 'llvm-tools-preview'
  2.1 MiB /   2.1 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: downloading component 'rust-analysis'
info: downloading component 'rust-src'
  1.3 MiB /   1.3 MiB (100 %)   1.3 MiB/s ETA:   0 s
info: downloading component 'rustfmt'
  2.2 MiB /   2.2 MiB (100 %)   1.2 MiB/s ETA:   0 s
info: removing component 'rustc'
info: removing component 'rust-std'
info: removing component 'cargo'
info: removing component 'rust-docs'
info: removing component 'rls'
info: removing component 'clippy'
info: removing component 'llvm-tools-preview'
info: removing component 'rust-analysis'
info: removing component 'rust-src'
info: removing component 'rustfmt'
info: installing component 'rustc'
info: installing component 'rust-std'
info: installing component 'cargo'
info: installing component 'rust-docs'
info: installing component 'rls'
info: installing component 'clippy'
info: installing component 'llvm-tools-preview'
info: installing component 'rust-analysis'
info: installing component 'rust-src'
info: installing component 'rustfmt'
info: checking for self-updates

  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.31.1 (b6c32da9b 2018-12-18)
    beta-x86_64-unknown-linux-gnu unchanged - rustc 1.32.0-beta.6 (a01b0bf0f 2018-12-19)
   nightly-x86_64-unknown-linux-gnu updated - rustc 1.33.0-nightly (14b96659e 2018-12-25)

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jan 3, 2019
…atsakis

bootstrap: Link LLVM as a dylib with ThinLTO (take 2)

When building a distributed compiler on Linux where we use ThinLTO to
create the LLVM shared object this commit switches the compiler to
dynamically linking that LLVM artifact instead of statically linking to
LLVM. The primary goal here is to reduce CI compile times, avoiding two+
ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll
reuse the one ThinLTO step done by LLVM's build itself.

Lots of discussion about this change can be found [here] and down. A
perf run will show whether this is worth it or not!

[here]: rust-lang#53245 (comment)

---

This PR previously landed in rust-lang#56944, caused rust-lang#57111, and was reverted in rust-lang#57116. I've added one more commit here which should fix the breakage that we saw.
bors added a commit that referenced this issue Jan 6, 2019
bootstrap: Link LLVM as a dylib with ThinLTO (take 2)

When building a distributed compiler on Linux where we use ThinLTO to
create the LLVM shared object this commit switches the compiler to
dynamically linking that LLVM artifact instead of statically linking to
LLVM. The primary goal here is to reduce CI compile times, avoiding two+
ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll
reuse the one ThinLTO step done by LLVM's build itself.

Lots of discussion about this change can be found [here] and down. A
perf run will show whether this is worth it or not!

[here]: #53245 (comment)

---

This PR previously landed in #56944, caused #57111, and was reverted in #57116. I've added one more commit here which should fix the breakage that we saw.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-linux Operating system: Linux O-macos Operating system: macOS P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants