-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup: nightly 2018-12-25 fails to install #57111
Comments
I checked verbose mode but didnt see anything interesting, just a ton of |
This also reproduces on travis ci: https://travis-ci.org/matthiaskrgr/cargo-cache/jobs/471994137#L434 |
cc @rust-lang/infra @rust-lang/dev-tools @pietroalbini @kennytm |
#56944 seems the most relevant. cc @alexcrichton |
Windows appears to be unaffected. |
PRs involved: ddab10a...f960f37 Failed to install on macOS too. |
I'm about 95% sure that this is #56944. It's fine to revert it quickly as I won't have time to make a fix until 2019! |
Revert #56944. This should fix #57111, since #56944 is the only PR involving LLVM. #57111 is caused by both the rustc and rust-std tarballs providing libLLVM. r? @alexcrichton
Hi I am still getting this error on macOS. I uninstalled all of my rust toolchains, so this nightly install would be in the only toolchain on my system. Should we reopen this bug? Error message:
|
This will be fixed on tomorrow's nightly (released around midnight UTC). |
Ay can we add a rustup installation test so that this is caught before uploading? |
Still not fixed there still issues?
|
I was able to successfully update now! :)
|
…atsakis bootstrap: Link LLVM as a dylib with ThinLTO (take 2) When building a distributed compiler on Linux where we use ThinLTO to create the LLVM shared object this commit switches the compiler to dynamically linking that LLVM artifact instead of statically linking to LLVM. The primary goal here is to reduce CI compile times, avoiding two+ ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll reuse the one ThinLTO step done by LLVM's build itself. Lots of discussion about this change can be found [here] and down. A perf run will show whether this is worth it or not! [here]: rust-lang#53245 (comment) --- This PR previously landed in rust-lang#56944, caused rust-lang#57111, and was reverted in rust-lang#57116. I've added one more commit here which should fix the breakage that we saw.
bootstrap: Link LLVM as a dylib with ThinLTO (take 2) When building a distributed compiler on Linux where we use ThinLTO to create the LLVM shared object this commit switches the compiler to dynamically linking that LLVM artifact instead of statically linking to LLVM. The primary goal here is to reduce CI compile times, avoiding two+ ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll reuse the one ThinLTO step done by LLVM's build itself. Lots of discussion about this change can be found [here] and down. A perf run will show whether this is worth it or not! [here]: #53245 (comment) --- This PR previously landed in #56944, caused #57111, and was reverted in #57116. I've added one more commit here which should fix the breakage that we saw.
Looks like I'm not getting a new nightly for Christmas 😢
The text was updated successfully, but these errors were encountered: